Skip to content

Commit 1a93242

Browse files
committed
fixes
1 parent cba28d9 commit 1a93242

File tree

1 file changed

+26
-7
lines changed

1 file changed

+26
-7
lines changed

FirebaseAuth/Tests/Unit/StartPasskeyEnrollmentResponseTests.swift

Lines changed: 26 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,13 @@
3636
XCTAssertEqual(response.challenge, "FAKE_CHALLENGE")
3737
}
3838

39-
func testInitWithMissingCredentialCreationOptionsThrowsError() {
39+
func testInitWithMissingCredentialCreationOptions() {
4040
let invalidDict: [String: AnyHashable] = [:]
41-
XCTAssertThrowsError(try StartPasskeyEnrollmentResponse(dictionary: invalidDict))
41+
XCTAssertThrowsError(try StartPasskeyEnrollmentResponse(dictionary: invalidDict)) { error in
42+
let nsError = error as NSError
43+
XCTAssertEqual(nsError.domain, AuthErrorDomain)
44+
XCTAssertEqual(nsError.code, AuthErrorCode.internalError.rawValue)
45+
}
4246
}
4347

4448
func testInitWithMissingRp() {
@@ -47,7 +51,11 @@
4751
options.removeValue(forKey: "rp")
4852
dict["credentialCreationOptions"] = options as? AnyHashable
4953
}
50-
XCTAssertThrowsError(try StartPasskeyEnrollmentResponse(dictionary: dict))
54+
XCTAssertThrowsError(try StartPasskeyEnrollmentResponse(dictionary: dict)) { error in
55+
let nsError = error as NSError
56+
XCTAssertEqual(nsError.domain, AuthErrorDomain)
57+
XCTAssertEqual(nsError.code, AuthErrorCode.internalError.rawValue)
58+
}
5159
}
5260

5361
func testInitWithMissingRpId() {
@@ -58,7 +66,11 @@
5866
options["rp"] = rp
5967
dict["credentialCreationOptions"] = options as? AnyHashable
6068
}
61-
XCTAssertThrowsError(try StartPasskeyEnrollmentResponse(dictionary: dict))
69+
XCTAssertThrowsError(try StartPasskeyEnrollmentResponse(dictionary: dict)) { error in
70+
let nsError = error as NSError
71+
XCTAssertEqual(nsError.domain, AuthErrorDomain)
72+
XCTAssertEqual(nsError.code, AuthErrorCode.internalError.rawValue)
73+
}
6274
}
6375

6476
func testInitWithMissingUser() {
@@ -67,7 +79,11 @@
6779
options.removeValue(forKey: "user")
6880
dict["credentialCreationOptions"] = options as? AnyHashable
6981
}
70-
XCTAssertThrowsError(try StartPasskeyEnrollmentResponse(dictionary: dict))
82+
XCTAssertThrowsError(try StartPasskeyEnrollmentResponse(dictionary: dict)) { error in
83+
let nsError = error as NSError
84+
XCTAssertEqual(nsError.domain, AuthErrorDomain)
85+
XCTAssertEqual(nsError.code, AuthErrorCode.internalError.rawValue)
86+
}
7187
}
7288

7389
func testInitWithMissingUserId() {
@@ -78,7 +94,11 @@
7894
options["user"] = user
7995
dict["credentialCreationOptions"] = options as? AnyHashable
8096
}
81-
XCTAssertThrowsError(try StartPasskeyEnrollmentResponse(dictionary: dict))
97+
XCTAssertThrowsError(try StartPasskeyEnrollmentResponse(dictionary: dict)) { error in
98+
let nsError = error as NSError
99+
XCTAssertEqual(nsError.domain, AuthErrorDomain)
100+
XCTAssertEqual(nsError.code, AuthErrorCode.internalError.rawValue)
101+
}
82102
}
83103

84104
func testInitWithMissingChallenge() {
@@ -100,7 +120,6 @@
100120
let expectedRpID = "example.com"
101121
let expectedUserID = "USER_123"
102122
let expectedChallenge = "FAKE_CHALLENGE"
103-
104123
rpcIssuer.respondBlock = {
105124
try self.rpcIssuer.respond(withJSON: [
106125
"credentialCreationOptions": [

0 commit comments

Comments
 (0)