[Infra] Install visionOS sims to workflows that couldn't find it (#14543)

Author: ncooke3

.github/workflows/abtesting.yml

@@ -120,6 +120,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@v3

.github/workflows/auth.yml

@@ -141,6 +141,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS spm'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@v3

.github/workflows/core.yml

@@ -101,6 +101,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - name: Unit Tests

.github/workflows/crashlytics.yml

@@ -116,6 +116,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@v3

.github/workflows/mlmodeldownloader.yml

@@ -131,6 +131,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - name: Unit Tests

.github/workflows/remoteconfig.yml

@@ -155,6 +155,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - name: Unit Tests

.github/workflows/sessions.yml

@@ -111,6 +111,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@v3

.github/workflows/vertexai.yml

@@ -81,6 +81,9 @@ jobs:
       run: scripts/update_vertexai_responses.sh
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@v3

Crashlytics/Crashlytics/Components/FIRCLSApplication.h

@@ -83,10 +83,6 @@ UIApplication* FIRCLSApplicationSharedInstance(void);
 id FIRCLSApplicationSharedInstance(void);
 #endif
 
-void FIRCLSApplicationOpenURL(NSURL* url,
-                              NSExtensionContext* extensionContext,
-                              void (^completionBlock)(BOOL success));
-
 id<NSObject> FIRCLSApplicationBeginActivity(NSActivityOptions options, NSString* reason);
 void FIRCLSApplicationEndActivity(id<NSObject> activity);
 

Crashlytics/Crashlytics/Components/FIRCLSApplication.m

@@ -155,32 +155,6 @@ id FIRCLSApplicationSharedInstance(void) {
 }
 #endif
 
-void FIRCLSApplicationOpenURL(NSURL* url,
-                              NSExtensionContext* extensionContext,
-                              void (^completionBlock)(BOOL success)) {
-  if (extensionContext) {
-    [extensionContext openURL:url completionHandler:completionBlock];
-    return;
-  }
-
-  BOOL result = NO;
-
-#if TARGET_OS_IOS
-  // What's going on here is the value returned is a scalar, but we really need an object to
-  // call this dynamically. Hoops must be jumped.
-  NSInvocationOperation* op =
-      [[NSInvocationOperation alloc] initWithTarget:FIRCLSApplicationSharedInstance()
-                                           selector:@selector(openURL:)
-                                             object:url];
-  [op start];
-  [op.result getValue:&result];
-#elif CLS_TARGET_OS_OSX
-  result = [[NSClassFromString(@"NSWorkspace") sharedWorkspace] openURL:url];
-#endif
-
-  completionBlock(result);
-}
-
 id<NSObject> FIRCLSApplicationBeginActivity(NSActivityOptions options, NSString* reason) {
   if ([[NSProcessInfo processInfo] respondsToSelector:@selector(beginActivityWithOptions:
                                                                                   reason:)]) {