[FirebaseCore] Add comment to notify future-us about potential side effects of code change (#11041)

ncooke3 · web-flow · commit 2617e60dd6ae · 2023-03-29T18:03:34.000-04:00
diff --git a/FirebaseCore/Sources/FIRApp.m b/FirebaseCore/Sources/FIRApp.m
@@ -876,6 +876,9 @@ - (void)subscribeForAppDidBecomeActiveNotifications {
 
 - (void)appDidBecomeActive:(NSNotification *)notification {
   if ([self isDataCollectionDefaultEnabled]) {
+    // If changing the below line, consult with the Games team to ensure they
+    // are not negatively impacted. For more details, see
+    // go/firebase-game-sdk-user-agent-register-timing.
     [self.heartbeatLogger log];
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -876,6 +876,9 @@ - (void)subscribeForAppDidBecomeActiveNotifications {`
`876`	`876`
`877`	`877`	`- (void)appDidBecomeActive:(NSNotification *)notification {`
`878`	`878`	`if ([self isDataCollectionDefaultEnabled]) {`
	`879`	`+ // If changing the below line, consult with the Games team to ensure they`
	`880`	`+ // are not negatively impacted. For more details, see`
	`881`	`+ // go/firebase-game-sdk-user-agent-register-timing.`
`879`	`882`	`[self.heartbeatLogger log];`
`880`	`883`	`}`
`881`	`884`	`}`