Skip to content

Commit 290c7e1

Browse files
Missing iid handler checking cause crash (#6737)
1 parent dd2e23e commit 290c7e1

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

Firebase/InstanceID/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Unreleased -- 7.0.0
22
- [changed] Deprecated private `-[FIRInstanceID appInstanceID:]` method was removed. (#4486)
3+
- [fixed] Fixed an issue that APNS token is not sent in token request when there's a delay of getting the APNS token from Apple. (#6553)
34

45
# 2020-09 -- 4.7.0
56
- [deprecated] Deprecated InstanceID. For app instance identity handling, use FirebaseInstallations. For FCM registration token handling, use FirebaseMessaging. (#6585)

Firebase/InstanceID/FIRInstanceIDTokenManager.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,9 @@ - (void)fetchNewTokenWithAuthorizedEntity:(NSString *)authorizedEntity
8989
NSError *_Nullable error) {
9090
FIRInstanceID_STRONGIFY(self);
9191
if (error) {
92-
handler(nil, error);
92+
if (handler) {
93+
handler(nil, error);
94+
}
9395
return;
9496
}
9597
NSString *firebaseAppID = options[kFIRInstanceIDTokenOptionsFirebaseAppIDKey];

FirebaseMessaging/CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
- [changed] Remove the deprecated FCM direct channel API and Upstream send API. (#6430)
33
- [changed] The `messaging:didReceiveRegistrationToken:` should be able to return a null token. Update the API parameter fcmToken to be nullable. (#5339)
44
- [fixed] Fixed an issue that downloading an image failed when there's no extension in the file name but MIME type is set. (#6590)
5-
- [fixed] Fixed an issue that APNS token is not sent in token request when there's a delay of getting the APNS token from Apple. (#6553)
65

76
# 2020-09 -- v.4.7.1
87
- [added] InstanceID is deprecated, add macro to suppress deprecation warning. (#6585)

0 commit comments

Comments
 (0)