Add -localPodspecPath option (#4453)

Author: paulb777

ZipBuilder/Sources/ZipBuilder/CocoaPodUtils.swift

@@ -171,10 +171,14 @@ public enum CocoaPodUtils {
     let podsDir = projectDir.appendingPathComponent("Pods")
     var installedPods: [String: PodInfo] = [:]
     for (podName, version) in pods {
-      let podDir = podsDir.appendingPathComponent(podName)
-      guard FileManager.default.directoryExists(at: podDir) else {
-        fatalError("Directory for \(podName) doesn't exist at \(podDir) - failed while getting " +
-          "information for installed Pods.")
+      var podDir = podsDir.appendingPathComponent(podName)
+      // Make sure that pod got installed if it's not coming from a local podspec.
+      if !FileManager.default.directoryExists(at: podDir) {
+        guard let repoDir = LaunchArgs.shared.localPodspecPath else {
+          fatalError("Directory for \(podName) doesn't exist at \(podDir) - failed while getting " +
+            "information for installed Pods.")
+        }
+        podDir = repoDir
       }
       let dependencies = [String](deps[podName] ?? [])
       let podInfo = PodInfo(version: version, dependencies: dependencies, installedLocation: podDir)
@@ -304,12 +308,38 @@ public enum CocoaPodUtils {
     target 'FrameworkMaker' do\n
     """
 
+    var versionsSpecified = false
+
     // Loop through the subspecs passed in and use the actual Pod name.
     for pod in pods {
-      let version = pod.version == nil ? "" : ", '\(pod.version!)'"
-      podfile += "  pod '\(pod.name)'" + version + "\n"
+      podfile += "  pod '\(pod.name)'"
+      // Check if we want to use a local version of the podspec.
+      if let localURL = LaunchArgs.shared.localPodspecPath,
+        FileManager.default.fileExists(atPath: localURL.appendingPathComponent(pod.name + ".podspec").path) {
+        podfile += ", :path => '\(localURL.path)'"
+      } else if let podVersion = pod.version {
+        podfile += ", '\(podVersion)'"
+      }
+      if pod.version != nil {
+        // Don't add Google pods if versions were specified or we're doing a secondary install
+        // to create module maps.
+        versionsSpecified = true
+      }
+      podfile += "\n"
     }
 
+    // If we're using local pods, explicitly add Google* podspecs if they exist and there are no
+    // explicit versions in the Podfile. Note there are versions for local podspecs if we're doing
+    // the secondary install for module map building.
+    if !versionsSpecified, let localURL = LaunchArgs.shared.localPodspecPath {
+      let podspecs = try! FileManager.default.contentsOfDirectory(atPath: localURL.path)
+      for podspec in podspecs {
+        if podspec.starts(with: "Google"), podspec.hasSuffix(".podspec") {
+          let podName = podspec.replacingOccurrences(of: ".podspec", with: "")
+          podfile += "  pod '\(podName)', :path => '\(localURL.path)/\(podspec)'\n"
+        }
+      }
+    }
     podfile += "end"
     return podfile
   }

ZipBuilder/Sources/ZipBuilder/LaunchArgs.swift

@@ -45,6 +45,7 @@ struct LaunchArgs {
     case customSpecRepos
     case existingVersions
     case keepBuildArtifacts
+    case localPodspecPath
     case minimumIOSVersion
     case outputDir
     case releasingSDKs
@@ -72,6 +73,8 @@ struct LaunchArgs {
           "of type `ZipBuilder_FirebaseSDKs`."
       case .keepBuildArtifacts:
         return "A flag to indicate keeping (not deleting) the build artifacts."
+      case .localPodspecPath:
+        return "Path to override podspec search with local podspec."
       case .minimumIOSVersion:
         return "The minimum supported iOS version. The default is 9.0."
       case .outputDir:
@@ -118,6 +121,9 @@ struct LaunchArgs {
   /// A flag to keep the build artifacts after this script completes.
   let keepBuildArtifacts: Bool
 
+  /// Path to override podspec search with local podspec.
+  let localPodspecPath: URL?
+
   /// The minimum iOS Version to build for.
   let minimumIOSVersion: String
 
@@ -238,6 +244,20 @@ struct LaunchArgs {
       outputDir = nil
     }
 
+    // Parse the local podspec search path.
+    if let localPath = defaults.string(forKey: Key.localPodspecPath.rawValue) {
+      let url = URL(fileURLWithPath: localPath)
+      guard fileChecker.directoryExists(at: url) else {
+        LaunchArgs.exitWithUsageAndLog("Could not parse \(Key.localPodspecPath) key: value " +
+          "passed in is not a file URL or the directory does not exist. Value: \(localPath)")
+      }
+
+      localPodspecPath = url.standardizedFileURL
+    } else {
+      // No argument was passed in.
+      localPodspecPath = nil
+    }
+
     // Parse the release candidate number. Note: if the String passed in isn't an integer, ignore
     // it and don't fail since we can append something else to the filenames.
     if let rcFlag = defaults.string(forKey: Key.rc.rawValue),

ZipBuilder/Sources/ZipBuilder/ZipBuilder.swift

@@ -671,13 +671,15 @@ struct ZipBuilder {
       }
 
       // Get all the frameworks contained in this directory.
-      var foundFrameworks: [URL]
-      do {
-        foundFrameworks = try fileManager.recursivelySearch(for: .frameworks,
-                                                            in: podInfo.installedLocation)
-      } catch {
-        fatalError("Cannot search for .framework files in Pods directory " +
-          "\(podInfo.installedLocation): \(error)")
+      var foundFrameworks: [URL] = []
+      if podInfo.installedLocation != LaunchArgs.shared.localPodspecPath {
+        do {
+          foundFrameworks = try fileManager.recursivelySearch(for: .frameworks,
+                                                              in: podInfo.installedLocation)
+        } catch {
+          fatalError("Cannot search for .framework files in Pods directory " +
+            "\(podInfo.installedLocation): \(error)")
+        }
       }
 
       // If there are no frameworks, it's an open source pod and we need to compile the source to