[Infra] Clean up 'AtomicBox' usage in favor of 'FIRAllocatedUnfairLock' (#15082)

Author: ncooke3

FirebaseCore/Internal/Sources/Utilities/AtomicBox.swift

@@ -25,36 +25,7 @@ import Foundation
 #endif
 
 internal import FirebaseCoreExtension
-
-final class AtomicBox<T>: Sendable {
-  private nonisolated(unsafe) var _value: T
-  private let lock = NSLock()
-
-  public init(_ value: T) where T: Sendable {
-    _value = value
-  }
-
-  public func value() -> T {
-    lock.withLock {
-      _value
-    }
-  }
-
-  @discardableResult
-  public func withLock(_ mutatingBody: (_ value: inout T) -> Void) -> T {
-    lock.withLock {
-      mutatingBody(&_value)
-      return _value
-    }
-  }
-
-  @discardableResult
-  public func withLock<R>(_ mutatingBody: (_ value: inout T) throws -> R) rethrows -> R {
-    try lock.withLock {
-      try mutatingBody(&_value)
-    }
-  }
-}
+private import FirebaseCoreInternal
 
 /// File specific constants.
 private enum Constants {
@@ -82,16 +53,15 @@ enum FunctionsConstants {
 
   /// A map of active instances, grouped by app. Keys are FirebaseApp names and values are arrays
   /// containing all instances of Functions associated with the given app.
-  private static let instances: AtomicBox<[String: [Functions]]> =
-    AtomicBox([:])
+  private static let instances = FIRAllocatedUnfairLock<[String: [Functions]]>(initialState: [:])
 
   /// The custom domain to use for all functions references (optional).
   let customDomain: String?
 
   /// The region to use for all function references.
   let region: String
 
-  private let _emulatorOrigin: AtomicBox<String?>
+  private let _emulatorOrigin: FIRAllocatedUnfairLock<String?>
 
   // MARK: - Public APIs
 
@@ -371,7 +341,7 @@ enum FunctionsConstants {
     self.projectID = projectID
     self.region = region
     self.customDomain = customDomain
-    _emulatorOrigin = AtomicBox(nil)
+    _emulatorOrigin = FIRAllocatedUnfairLock(initialState: nil)
     contextProvider = FunctionsContextProvider(auth: auth,
                                                messaging: messaging,
                                                appCheck: appCheck)

FirebaseFunctions/Sources/Functions.swift

@@ -14,6 +14,8 @@
 
 import Foundation
 
+private import FirebaseCoreInternal
+
 /// A `HTTPSCallableResult` contains the result of calling a `HTTPSCallable`.
 @objc(FIRHTTPSCallableResult)
 open class HTTPSCallableResult: NSObject {
@@ -163,7 +165,7 @@ private extension HTTPSCallable {
 
     // MARK: - Public Properties
 
-    let _timeoutInterval: AtomicBox<TimeInterval> = .init(70)
+    let _timeoutInterval = FIRAllocatedUnfairLock<TimeInterval>(initialState: 70)
 
     /// The timeout to use when calling the function. Defaults to 70 seconds.
     var timeoutInterval: TimeInterval {

FirebaseFunctions/Sources/HTTPSCallable.swift

@@ -15,27 +15,7 @@
 
 import Foundation
 
-private final class AtomicBox<T> {
-  private var _value: T
-  private let lock = NSLock()
-
-  init(_ value: T) {
-    _value = value
-  }
-
-  func value() -> T {
-    lock.withLock {
-      _value
-    }
-  }
-
-  @discardableResult func withLock(_ body: (_ value: inout T) -> Void) -> T {
-    lock.withLock {
-      body(&_value)
-      return _value
-    }
-  }
-}
+private import FirebaseCoreInternal
 
 /// Sessions Dependencies determines when a dependent SDK is
 /// installed in the app. The Sessions SDK uses this to figure
@@ -46,10 +26,8 @@ private final class AtomicBox<T> {
 /// dependent SDKs
 @objc(FIRSessionsDependencies)
 public class SessionsDependencies: NSObject {
-  private nonisolated(unsafe) static let _dependencies: AtomicBox<Set<SessionsSubscriberName>> =
-    AtomicBox(
-      Set()
-    )
+  private static let _dependencies =
+    FIRAllocatedUnfairLock<Set<SessionsSubscriberName>>(initialState: Set())
 
   static var dependencies: Set<SessionsSubscriberName> {
     _dependencies.value()