Fix sanitizer issues (#4043)

Fixes #4039
Fixes #4027

Author: mikehaney24

GoogleDataTransport/GDTCORLibrary/GDTCORStorage.m

@@ -217,7 +217,9 @@ - (void)appWillForeground:(GDTCORApplication *)app {
   if (@available(macOS 10.13, iOS 11.0, tvOS 11.0, *)) {
     NSError *error;
     NSData *data = [NSData dataWithContentsOfFile:[GDTCORStorage archivePath]];
-    [NSKeyedUnarchiver unarchivedObjectOfClass:[GDTCORStorage class] fromData:data error:&error];
+    if (data) {
+      [NSKeyedUnarchiver unarchivedObjectOfClass:[GDTCORStorage class] fromData:data error:&error];
+    }
   } else {
 #if !TARGET_OS_MACCATALYST
     [NSKeyedUnarchiver unarchiveObjectWithFile:[GDTCORStorage archivePath]];

GoogleDataTransport/GDTCORLibrary/GDTCORUploadCoordinator.m

@@ -180,8 +180,8 @@ - (void)encodeWithCoder:(NSCoder *)aCoder {
   dispatch_sync(_coordinationQueue, ^{
     // All packages that have been given to uploaders need to be tracked so that their expiration
     // timers can be called.
-    if (_targetToInFlightPackages.count > 0) {
-      [aCoder encodeObject:_targetToInFlightPackages forKey:ktargetToInFlightPackagesKey];
+    if (self->_targetToInFlightPackages.count > 0) {
+      [aCoder encodeObject:self->_targetToInFlightPackages forKey:ktargetToInFlightPackagesKey];
     }
   });
 }

GoogleDataTransportCCTSupport/GDTCCTLibrary/GDTCCTUploader.m

@@ -116,15 +116,17 @@ - (void)uploadPackage:(GDTCORUploadPackage *)package {
         GDTCORLogWarning(GDTCORMCWUploadFailed, @"There was an error uploading events: %@", error);
       }
       NSError *decodingError;
-      gdt_cct_LogResponse logResponse = GDTCCTDecodeLogResponse(data, &decodingError);
-      if (!decodingError && logResponse.has_next_request_wait_millis) {
-        self->_nextUploadTime =
-            [GDTCORClock clockSnapshotInTheFuture:logResponse.next_request_wait_millis];
-      } else {
-        // 15 minutes from now.
-        self->_nextUploadTime = [GDTCORClock clockSnapshotInTheFuture:15 * 60 * 1000];
+      if (data) {
+        gdt_cct_LogResponse logResponse = GDTCCTDecodeLogResponse(data, &decodingError);
+        if (!decodingError && logResponse.has_next_request_wait_millis) {
+          self->_nextUploadTime =
+              [GDTCORClock clockSnapshotInTheFuture:logResponse.next_request_wait_millis];
+        } else {
+          // 15 minutes from now.
+          self->_nextUploadTime = [GDTCORClock clockSnapshotInTheFuture:15 * 60 * 1000];
+        }
+        pb_release(gdt_cct_LogResponse_fields, &logResponse);
       }
-      pb_release(gdt_cct_LogResponse_fields, &logResponse);
 #if !NDEBUG
       // Post a notification when in DEBUG mode to state how many packages were uploaded. Useful
       // for validation during tests.

GoogleDataTransportCCTSupport/GDTCCTLibrary/GDTFLLUploader.m

@@ -141,15 +141,17 @@ - (void)uploadPackage:(GDTCORUploadPackage *)package {
         GDTCORLogWarning(GDTCORMCWUploadFailed, @"There was an error uploading events: %@", error);
       }
       NSError *decodingError;
-      gdt_cct_LogResponse logResponse = GDTCCTDecodeLogResponse(data, &decodingError);
-      if (!decodingError && logResponse.has_next_request_wait_millis) {
-        self->_nextUploadTime =
-            [GDTCORClock clockSnapshotInTheFuture:logResponse.next_request_wait_millis];
-      } else {
-        // 15 minutes from now.
-        self->_nextUploadTime = [GDTCORClock clockSnapshotInTheFuture:15 * 60 * 1000];
+      if (data) {
+        gdt_cct_LogResponse logResponse = GDTCCTDecodeLogResponse(data, &decodingError);
+        if (!decodingError && logResponse.has_next_request_wait_millis) {
+          self->_nextUploadTime =
+              [GDTCORClock clockSnapshotInTheFuture:logResponse.next_request_wait_millis];
+        } else {
+          // 15 minutes from now.
+          self->_nextUploadTime = [GDTCORClock clockSnapshotInTheFuture:15 * 60 * 1000];
+        }
+        pb_release(gdt_cct_LogResponse_fields, &logResponse);
       }
-      pb_release(gdt_cct_LogResponse_fields, &logResponse);
 
       // Only retry if one of these codes is returned.
       if (((NSHTTPURLResponse *)response).statusCode == 429 ||