Skip to content

Commit 3af0241

Browse files
authored
Update OR query Swift tests. (#11969)
1 parent 33cf815 commit 3af0241

File tree

1 file changed

+0
-33
lines changed

1 file changed

+0
-33
lines changed

Firestore/Swift/Tests/Integration/QueryIntegrationTests.swift

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -185,31 +185,6 @@ class QueryIntegrationTests: FSTIntegrationTestCase {
185185
matchesResult: ["doc3", "doc4", "doc6"])
186186
}
187187

188-
func testOrQueriesWithNotIn() throws {
189-
// TODO(orquery): Enable this test against production when possible.
190-
try XCTSkipIf(!FSTIntegrationTestCase.isRunningAgainstEmulator(),
191-
"Skip this test if running against production because it results in " +
192-
"a 'missing index' error. The Firestore Emulator, however, does serve these queries")
193-
194-
let collRef = collectionRef(
195-
withDocuments: ["doc1": ["a": 1, "b": 0],
196-
"doc2": ["b": 1],
197-
"doc3": ["a": 3, "b": 2],
198-
"doc4": ["a": 1, "b": 3],
199-
"doc5": ["a": 1],
200-
"doc6": ["a": 2]]
201-
)
202-
203-
// a==2 || b not-in [2,3]
204-
// Has implicit orderBy b.
205-
let filter = Filter.orFilter(
206-
[Filter.whereField("a", isEqualTo: 2),
207-
Filter.whereField("b", notIn: [2, 3])]
208-
)
209-
checkOnlineAndOfflineQuery(collRef.whereFilter(filter),
210-
matchesResult: ["doc1", "doc2"])
211-
}
212-
213188
func testOrQueriesWithArrayMembership() throws {
214189
let collRef = collectionRef(
215190
withDocuments: ["doc1": ["a": 1, "b": [0]],
@@ -238,10 +213,6 @@ class QueryIntegrationTests: FSTIntegrationTestCase {
238213
}
239214

240215
func testMultipleInOps() throws {
241-
// TODO(orquery): Enable this test against production when possible.
242-
try XCTSkipIf(!FSTIntegrationTestCase.isRunningAgainstEmulator(),
243-
"Skip this test if running against production because it's not yet supported.")
244-
245216
let collRef = collectionRef(
246217
withDocuments: ["doc1": ["a": 1, "b": 0],
247218
"doc2": ["b": 1],
@@ -270,10 +241,6 @@ class QueryIntegrationTests: FSTIntegrationTestCase {
270241
}
271242

272243
func testUsingInWithArrayContainsAny() throws {
273-
// TODO(orquery): Enable this test against production when possible.
274-
try XCTSkipIf(!FSTIntegrationTestCase.isRunningAgainstEmulator(),
275-
"Skip this test if running against production because it's not yet supported.")
276-
277244
let collRef = collectionRef(
278245
withDocuments: ["doc1": ["a": 1, "b": [0]],
279246
"doc2": ["b": [1]],

0 commit comments

Comments
 (0)