Add a validation check to Settings (#8019)

var-const · web-flow · commit 3cce657d7506 · 2021-05-19T22:19:50.000-04:00
This is for consistency with other platforms (e.g. [Android](https://github.com/firebase/firebase-android-sdk/blob/3f0779ede98e4aa6986844a767c7f0eebc9d19b5/firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestoreSettings.java#L141-L144)).
diff --git a/Firestore/core/src/api/firestore.cc b/Firestore/core/src/api/firestore.cc
@@ -111,7 +111,7 @@ void Firestore::set_settings(const Settings& settings) {
   }
   if (!settings.ssl_enabled() && settings.host() == Settings::DefaultHost) {
     util::ThrowIllegalState(
-        "You can't set the 'sslEnabled' setting unless you also set a "
+        "You can't set the 'sslEnabled' setting to false unless you also set a "
         "non-default 'host'.");
   }
 

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ void Firestore::set_settings(const Settings& settings) {`
`111`	`111`	`}`
`112`	`112`	`if (!settings.ssl_enabled() && settings.host() == Settings::DefaultHost) {`
`113`	`113`	`util::ThrowIllegalState(`
`114`		`- "You can't set the 'sslEnabled' setting unless you also set a "`
	`114`	`+ "You can't set the 'sslEnabled' setting to false unless you also set a "`
`115`	`115`	`"non-default 'host'.");`
`116`	`116`	`}`
`117`	`117`