fix: Crashlytics defer API calls until async context initialization completes (#15879)

Author: mghaznav

Crashlytics/CHANGELOG.md

@@ -1,3 +1,6 @@
+# Unreleased
+- [fixed] Fixed an issue where Crashlytics API calls were silently dropped if invoked immediately after Firebase initialization.
+
 # 12.10.0
 - [fixed] Fixed a deadlock in Firebase Sessions where the main thread could
   block waiting for a lock held by a background thread during settings

Crashlytics/Crashlytics/Components/FIRCLSUserLogging.m

@@ -241,6 +241,8 @@ void FIRCLSUserLoggingRecordKeysAndValues(NSDictionary *keysAndValues,
                                           FIRCLSUserLoggingKVStorage *storage,
                                           uint32_t *counter) {
   if (!FIRCLSContextIsInitialized()) {
+    FIRCLSSDKLogWarn(
+        "Failed to write key/value pairs. Crashlytics context has not initialized yet.\n");
     return;
   }
 
@@ -317,6 +319,8 @@ static void FIRCLSUserLoggingWriteKeysAndValues(NSDictionary *keysAndValues,
 
 NSArray *FIRCLSUserLoggingStoredKeyValues(const char *path) {
   if (!FIRCLSContextIsInitialized()) {
+    FIRCLSSDKLogWarn(
+        "Failed to read key/value pairs. Crashlytics context has not initialized yet.\n");
     return nil;
   }
 
@@ -394,6 +398,7 @@ void FIRCLSUserLoggingRecordError(NSError *error,
   }
 
   if (!FIRCLSContextIsInitialized()) {
+    FIRCLSSDKLogWarn("Failed to record error. Crashlytics context has not initialized yet.\n");
     return;
   }
 

Crashlytics/Crashlytics/FIRCrashlytics.m

@@ -311,7 +311,10 @@ - (void)processDidCrashDuringPreviousExecution {
 
 #pragma mark - API: Logging
 - (void)log:(NSString *)msg {
-  FIRCLSLog(@"%@", msg);
+  [self waitForContextInit:@"log"
+                  callback:^{
+                    FIRCLSLog(@"%@", msg);
+                  }];
 }
 
 - (void)logWithFormat:(NSString *)format, ... {
@@ -354,17 +357,26 @@ - (void)deleteUnsentReports {
 
 #pragma mark - API: setUserID
 - (void)setUserID:(nullable NSString *)userID {
-  FIRCLSUserLoggingRecordInternalKeyValue(FIRCLSUserIdentifierKey, userID);
+  [self waitForContextInit:@"setUserID"
+                  callback:^{
+                    FIRCLSUserLoggingRecordInternalKeyValue(FIRCLSUserIdentifierKey, userID);
+                  }];
 }
 
 #pragma mark - API: setCustomValue
 
 - (void)setCustomValue:(nullable id)value forKey:(NSString *)key {
-  FIRCLSUserLoggingRecordUserKeyValue(key, value);
+  [self waitForContextInit:@"setCustomValue"
+                  callback:^{
+                    FIRCLSUserLoggingRecordUserKeyValue(key, value);
+                  }];
 }
 
 - (void)setCustomKeysAndValues:(NSDictionary *)keysAndValues {
-  FIRCLSUserLoggingRecordUserKeysAndValues(keysAndValues);
+  [self waitForContextInit:@"setCustomKeysAndValues"
+                  callback:^{
+                    FIRCLSUserLoggingRecordUserKeysAndValues(keysAndValues);
+                  }];
 }
 
 #pragma mark - API: Development Platform
@@ -414,19 +426,29 @@ - (void)recordError:(NSError *)error {
 
 - (void)recordError:(NSError *)error userInfo:(NSDictionary<NSString *, id> *)userInfo {
   NSString *rolloutsInfoJSON = [_remoteConfigManager getRolloutAssignmentsEncodedJsonString];
-  FIRCLSUserLoggingRecordError(error, userInfo, rolloutsInfoJSON);
+  [self waitForContextInit:@"recordError"
+                  callback:^{
+                    FIRCLSUserLoggingRecordError(error, userInfo, rolloutsInfoJSON);
+                  }];
 }
 
 - (void)recordExceptionModel:(FIRExceptionModel *)exceptionModel {
   NSString *rolloutsInfoJSON = [_remoteConfigManager getRolloutAssignmentsEncodedJsonString];
-  FIRCLSExceptionRecordModel(exceptionModel, rolloutsInfoJSON);
+  [self waitForContextInit:@"recordExceptionModel"
+                  callback:^{
+                    FIRCLSExceptionRecordModel(exceptionModel, rolloutsInfoJSON);
+                  }];
 }
 
 - (void)recordOnDemandExceptionModel:(FIRExceptionModel *)exceptionModel {
-  [self.managerData.onDemandModel
-      recordOnDemandExceptionIfQuota:exceptionModel
-           withDataCollectionEnabled:[self.dataArbiter isCrashlyticsCollectionEnabled]
-          usingExistingReportManager:self.existingReportManager];
+  [self waitForContextInit:@"recordOnDemandExceptionModel"
+                  callback:^{
+                    [self.managerData.onDemandModel
+                        recordOnDemandExceptionIfQuota:exceptionModel
+                             withDataCollectionEnabled:[self.dataArbiter
+                                                               isCrashlyticsCollectionEnabled]
+                            usingExistingReportManager:self.existingReportManager];
+                  }];
 }
 
 #pragma mark - FIRSessionsSubscriber
@@ -456,7 +478,7 @@ - (void)rolloutsStateDidChange:(FIRRolloutsState *_Nonnull)rolloutsState {
                                                     reportID:currentReportID];
 }
 
-#pragma mark - Private Helpsers
+#pragma mark - Private Helpers
 - (void)waitForContextInit:(NSString *)contextLog callback:(void (^)(void))callback {
   if (!_contextInitPromise) {
     FIRCLSErrorLog(@"Crashlytics method called before SDK was initialized: %@", contextLog);