Skip to content

Commit 3e34931

Browse files
paulb777paulb777
authored
Disable quickstart CI that doesn't work with Xcode 15 (#12846)
1 parent 88c47ba commit 3e34931

File tree

4 files changed

+144
-142
lines changed

4 files changed

+144
-142
lines changed

‎.github/workflows/functions.yml‎

Lines changed: 60 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -110,68 +110,69 @@ jobs:
110110
- name: Unit Tests
111111
run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFunctionsUnit ${{ matrix.target }} spm
112112

113-
quickstart:
114-
# Don't run on private repo unless it is a PR.
115-
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
116-
env:
117-
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
118-
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
119-
LEGACY: true
120-
# TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
121-
runs-on: macos-12
113+
# TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
114+
# quickstart:
115+
# # Don't run on private repo unless it is a PR.
116+
# if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
117+
# env:
118+
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
119+
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
120+
# LEGACY: true
121+
# # TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
122+
# runs-on: macos-12
122123

123-
steps:
124-
- uses: actions/checkout@v4
125-
- uses: ruby/setup-ruby@v1
126-
- name: Setup quickstart
127-
run: scripts/setup_quickstart.sh functions
128-
- name: install secret googleservice-info.plist
129-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
130-
quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
131-
- name: Setup custom URL scheme
132-
run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
133-
- name: Test objc quickstart
134-
run: ([ -z $plist_secret ] ||
135-
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
136-
- name: Test swift quickstart
137-
run: ([ -z $plist_secret ] ||
138-
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
124+
# steps:
125+
# - uses: actions/checkout@v4
126+
# - uses: ruby/setup-ruby@v1
127+
# - name: Setup quickstart
128+
# run: scripts/setup_quickstart.sh functions
129+
# - name: install secret googleservice-info.plist
130+
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
131+
# quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
132+
# - name: Setup custom URL scheme
133+
# run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
134+
# - name: Test objc quickstart
135+
# run: ([ -z $plist_secret ] ||
136+
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
137+
# - name: Test swift quickstart
138+
# run: ([ -z $plist_secret ] ||
139+
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
139140

140-
quickstart-ftl-cron-only:
141-
# Don't run on private repo
142-
if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule'
143-
env:
144-
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
145-
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
146-
LEGACY: true
147-
# TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
148-
runs-on: macos-12
141+
# quickstart-ftl-cron-only:
142+
# # Don't run on private repo
143+
# if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule'
144+
# env:
145+
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
146+
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
147+
# LEGACY: true
148+
# # TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
149+
# runs-on: macos-12
149150

150-
steps:
151-
- uses: actions/checkout@v4
152-
- uses: ruby/setup-ruby@v1
153-
- uses: actions/setup-python@v4
154-
with:
155-
python-version: '3.11'
156-
- name: Setup quickstart
157-
run: scripts/setup_quickstart.sh functions
158-
- name: install secret googleservice-info.plist
159-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
160-
quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
161-
- name: Setup custom URL scheme
162-
run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
163-
- name: Build objc quickstart
164-
run: ([ -z $plist_secret ] ||
165-
scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Functions)
166-
- name: Build swift quickstart
167-
run: ([ -z $plist_secret ] ||
168-
scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Functions swift)
169-
- id: ftl_test
170-
uses: FirebaseExtended/github-actions/[email protected]
171-
with:
172-
credentials_json: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIALS }}
173-
testapp_dir: quickstart-ios/build-for-testing
174-
test_type: "xctest"
151+
# steps:
152+
# - uses: actions/checkout@v4
153+
# - uses: ruby/setup-ruby@v1
154+
# - uses: actions/setup-python@v4
155+
# with:
156+
# python-version: '3.11'
157+
# - name: Setup quickstart
158+
# run: scripts/setup_quickstart.sh functions
159+
# - name: install secret googleservice-info.plist
160+
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
161+
# quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
162+
# - name: Setup custom URL scheme
163+
# run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
164+
# - name: Build objc quickstart
165+
# run: ([ -z $plist_secret ] ||
166+
# scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Functions)
167+
# - name: Build swift quickstart
168+
# run: ([ -z $plist_secret ] ||
169+
# scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Functions swift)
170+
# - id: ftl_test
171+
# uses: FirebaseExtended/github-actions/[email protected]
172+
# with:
173+
# credentials_json: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIALS }}
174+
# testapp_dir: quickstart-ios/build-for-testing
175+
# test_type: "xctest"
175176

176177
functions-cron-only:
177178
# Don't run on private repo.

‎.github/workflows/prerelease.yml‎

Lines changed: 41 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -434,47 +434,48 @@ jobs:
434434
name: quickstart_artifacts_firestore
435435
path: quickstart-ios/
436436

437-
functions_quickstart:
437+
# TODO: The functions quickstart uses Material which isn't supported by Xcode 15
438+
#functions_quickstart:
438439
# Don't run on private repo unless it is a PR.
439-
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch'
440-
needs: buildup_SpecsTesting_repo
441-
env:
442-
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
443-
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
444-
bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
445-
testing_repo_dir: "/tmp/test/"
446-
testing_repo: "firebase-ios-sdk"
447-
LEGACY: true
448-
# TODO: The functions quickstart uses Material which isn't supported by Xcode 15
449-
runs-on: macos-12
450-
steps:
451-
- uses: actions/checkout@v4
452-
- uses: ruby/setup-ruby@v1
453-
- name: Get token
454-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/bot-access.txt.gpg \
455-
bot-access.txt "$bot_token_secret"
456-
- name: Setup testing repo and quickstart
457-
run: |
458-
botaccess=`cat bot-access.txt`
459-
BOT_TOKEN="${botaccess}" scripts/setup_quickstart.sh functions prerelease_testing
460-
- name: install secret googleservice-info.plist
461-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
462-
quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
463-
- name: Setup custom URL scheme
464-
run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
465-
- name: Test objc quickstart
466-
run: ([ -z $plist_secret ] ||
467-
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
468-
- name: Test swift quickstart
469-
run: ([ -z $plist_secret ] ||
470-
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
471-
- name: Remove data before upload
472-
run: scripts/remove_data.sh functions release_testing
473-
- uses: actions/upload-artifact@v4
474-
if: ${{ failure() }}
475-
with:
476-
name: quickstart_artifacts_functions
477-
path: quickstart-ios/
440+
# if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch'
441+
# needs: buildup_SpecsTesting_repo
442+
# env:
443+
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
444+
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
445+
# bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
446+
# testing_repo_dir: "/tmp/test/"
447+
# testing_repo: "firebase-ios-sdk"
448+
# LEGACY: true
449+
# # TODO: The functions quickstart uses Material which isn't supported by Xcode 15
450+
# runs-on: macos-12
451+
# steps:
452+
# - uses: actions/checkout@v4
453+
# - uses: ruby/setup-ruby@v1
454+
# - name: Get token
455+
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/bot-access.txt.gpg \
456+
# bot-access.txt "$bot_token_secret"
457+
# - name: Setup testing repo and quickstart
458+
# run: |
459+
# botaccess=`cat bot-access.txt`
460+
# BOT_TOKEN="${botaccess}" scripts/setup_quickstart.sh functions prerelease_testing
461+
# - name: install secret googleservice-info.plist
462+
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
463+
# quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
464+
# - name: Setup custom URL scheme
465+
# run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
466+
# - name: Test objc quickstart
467+
# run: ([ -z $plist_secret ] ||
468+
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
469+
# - name: Test swift quickstart
470+
# run: ([ -z $plist_secret ] ||
471+
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
472+
# - name: Remove data before upload
473+
# run: scripts/remove_data.sh functions release_testing
474+
# - uses: actions/upload-artifact@v4
475+
# if: ${{ failure() }}
476+
# with:
477+
# name: quickstart_artifacts_functions
478+
# path: quickstart-ios/
478479

479480
inappmessaging_quickstart:
480481
# Don't run on private repo unless it is a PR.

‎.github/workflows/release.yml‎

Lines changed: 41 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -385,47 +385,47 @@ jobs:
385385
name: quickstart_artifacts_firestore
386386
path: quickstart-ios/
387387

388-
functions_quickstart:
389-
# Don't run on private repo unless it is a PR.
390-
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch'
391-
needs: buildup_SpecsTesting_repo
392-
env:
393-
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
394-
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
395-
bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
396-
testing_repo_dir: "/tmp/test/"
397-
testing_repo: "firebase-ios-sdk"
398-
LEGACY: true
399-
# TODO: The functions quickstart uses Material which isn't supported by Xcode 15
400-
runs-on: macos-12
401-
steps:
402-
- uses: actions/checkout@v4
403-
- uses: ruby/setup-ruby@v1
404-
- name: Get token
405-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/bot-access.txt.gpg \
406-
bot-access.txt "$bot_token_secret"
407-
- name: Setup testing repo and quickstart
408-
run: |
409-
botaccess=`cat bot-access.txt`
410-
BOT_TOKEN="${botaccess}" scripts/setup_quickstart.sh functions nightly_release_testing
411-
- name: install secret googleservice-info.plist
412-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
413-
quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
414-
- name: Setup custom URL scheme
415-
run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
416-
- name: Test objc quickstart
417-
run: ([ -z $plist_secret ] ||
418-
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
419-
- name: Test swift quickstart
420-
run: ([ -z $plist_secret ] ||
421-
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
422-
- name: Remove data before upload
423-
run: scripts/remove_data.sh functions release_testing
424-
- uses: actions/upload-artifact@v4
425-
if: ${{ failure() }}
426-
with:
427-
name: quickstart_artifacts_functions
428-
path: quickstart-ios/
388+
# TODO: The functions quickstart uses Material which isn't supported by Xcode 15
389+
# functions_quickstart:
390+
# # Don't run on private repo unless it is a PR.
391+
# if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch'
392+
# needs: buildup_SpecsTesting_repo
393+
# env:
394+
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
395+
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
396+
# bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
397+
# testing_repo_dir: "/tmp/test/"
398+
# testing_repo: "firebase-ios-sdk"
399+
# LEGACY: true
400+
# runs-on: macos-12
401+
# steps:
402+
# - uses: actions/checkout@v4
403+
# - uses: ruby/setup-ruby@v1
404+
# - name: Get token
405+
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/bot-access.txt.gpg \
406+
# bot-access.txt "$bot_token_secret"
407+
# - name: Setup testing repo and quickstart
408+
# run: |
409+
# botaccess=`cat bot-access.txt`
410+
# BOT_TOKEN="${botaccess}" scripts/setup_quickstart.sh functions nightly_release_testing
411+
# - name: install secret googleservice-info.plist
412+
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
413+
# quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
414+
# - name: Setup custom URL scheme
415+
# run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
416+
# - name: Test objc quickstart
417+
# run: ([ -z $plist_secret ] ||
418+
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
419+
# - name: Test swift quickstart
420+
# run: ([ -z $plist_secret ] ||
421+
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
422+
# - name: Remove data before upload
423+
# run: scripts/remove_data.sh functions release_testing
424+
# - uses: actions/upload-artifact@v4
425+
# if: ${{ failure() }}
426+
# with:
427+
# name: quickstart_artifacts_functions
428+
# path: quickstart-ios/
429429

430430
inappmessaging_quickstart:
431431
# Don't run on private repo unless it is a PR.

‎.github/workflows/storage.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ jobs:
9696
strategy:
9797
matrix:
9898
include:
99-
- os: macos-13
100-
xcode: Xcode_14.2 # TODO: the legacy ObjC quickstart doesn't build with Xcode 15.
99+
#- os: macos-13
100+
# xcode: Xcode_14.2 # TODO: the legacy ObjC quickstart doesn't build with Xcode 15.
101101
- swift: swift
102102
os: macos-14
103103
xcode: Xcode_15.3

0 commit comments

Comments
 (0)