Migrate FSTPersistenceTestHelpers to C++ (#4122)

* Move FSTPersistenceHelpers to core/test/.../local

* Rewrite persistence_testing in C++

* Migrate from FSTPersistenceTestHelpers to C++ persistence_testing

* Rename .mm to .cc where possible in IndexManager tests

* Remove Objective-C gunk from index_manager_test.h

Author: wilhuff

Firestore/Example/Firestore.xcodeproj/project.pbxproj

@@ -18,16 +18,16 @@
 
 #import "Firestore/Example/Tests/Local/FSTLRUGarbageCollectorTests.h"
 
-#import "Firestore/Example/Tests/Local/FSTPersistenceTestHelpers.h"
-
 #include "Firestore/core/src/firebase/firestore/local/leveldb_key.h"
 #include "Firestore/core/src/firebase/firestore/local/leveldb_persistence.h"
 #include "Firestore/core/src/firebase/firestore/local/lru_garbage_collector.h"
 #include "Firestore/core/src/firebase/firestore/local/persistence.h"
 #include "Firestore/core/src/firebase/firestore/model/document_key.h"
+#include "Firestore/core/test/firebase/firestore/local/persistence_testing.h"
 
 using firebase::firestore::local::LevelDbDocumentTargetKey;
 using firebase::firestore::local::LevelDbPersistence;
+using firebase::firestore::local::LevelDbPersistenceForTesting;
 using firebase::firestore::local::Persistence;
 using firebase::firestore::model::DocumentKey;
 
@@ -41,7 +41,7 @@ @interface FSTLevelDBLRUGarbageCollectorTests : FSTLRUGarbageCollectorTests
 @implementation FSTLevelDBLRUGarbageCollectorTests
 
 - (std::unique_ptr<Persistence>)newPersistenceWithLruParams:(LruParams)lruParams {
-  return [FSTPersistenceTestHelpers levelDBPersistenceWithLruParams:lruParams];
+  return LevelDbPersistenceForTesting(lruParams);
 }
 
 - (BOOL)sentinelExists:(const DocumentKey &)key {

Firestore/Example/Tests/Local/FSTLevelDBLRUGarbageCollectorTests.mm

@@ -16,12 +16,12 @@
 
 #import "Firestore/Example/Tests/Local/FSTLocalStoreTests.h"
 
-#import "Firestore/Example/Tests/Local/FSTPersistenceTestHelpers.h"
-
 #include "Firestore/core/src/firebase/firestore/local/leveldb_persistence.h"
+#include "Firestore/core/test/firebase/firestore/local/persistence_testing.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
+using firebase::firestore::local::LevelDbPersistenceForTesting;
 using firebase::firestore::local::Persistence;
 
 /**
@@ -35,7 +35,7 @@ @interface FSTLevelDBLocalStoreTests : FSTLocalStoreTests
 @implementation FSTLevelDBLocalStoreTests
 
 - (std::unique_ptr<Persistence>)persistence {
-  return [FSTPersistenceTestHelpers levelDBPersistence];
+  return LevelDbPersistenceForTesting();
 }
 
 - (BOOL)gcIsEager {

Firestore/Example/Tests/Local/FSTLevelDBLocalStoreTests.mm

@@ -28,16 +28,17 @@
 #include "Firestore/core/src/firebase/firestore/local/leveldb_migrations.h"
 #include "Firestore/core/src/firebase/firestore/local/leveldb_query_cache.h"
 #include "Firestore/core/src/firebase/firestore/util/ordered_code.h"
+#include "Firestore/core/src/firebase/firestore/util/path.h"
+#include "Firestore/core/test/firebase/firestore/local/persistence_testing.h"
 #include "Firestore/core/test/firebase/firestore/testutil/testutil.h"
 #include "absl/strings/match.h"
 #include "leveldb/db.h"
 
-#import "Firestore/Example/Tests/Local/FSTPersistenceTestHelpers.h"
-
 NS_ASSUME_NONNULL_BEGIN
 
 using firebase::firestore::Error;
 using firebase::firestore::local::LevelDbCollectionParentKey;
+using firebase::firestore::local::LevelDbDir;
 using firebase::firestore::local::LevelDbDocumentMutationKey;
 using firebase::firestore::local::LevelDbDocumentTargetKey;
 using firebase::firestore::local::LevelDbMigrations;
@@ -75,7 +76,7 @@ - (void)setUp {
   options.error_if_exists = true;
   options.create_if_missing = true;
 
-  Path dir = [FSTPersistenceTestHelpers levelDBDir];
+  Path dir = LevelDbDir();
   DB *db;
   Status status = DB::Open(options, dir.ToUtf8String(), &db);
   XCTAssert(status.ok(), @"Failed to create db: %s", status.ToString().c_str());

Firestore/Example/Tests/Local/FSTLevelDBMigrationsTests.mm

@@ -20,7 +20,6 @@
 #include <vector>
 
 #import "Firestore/Example/Tests/Local/FSTMutationQueueTests.h"
-#import "Firestore/Example/Tests/Local/FSTPersistenceTestHelpers.h"
 #import "Firestore/Protos/objc/firestore/local/Mutation.pbobjc.h"
 
 #include "Firestore/core/src/firebase/firestore/auth/user.h"
@@ -29,6 +28,7 @@
 #include "Firestore/core/src/firebase/firestore/local/leveldb_persistence.h"
 #include "Firestore/core/src/firebase/firestore/local/reference_set.h"
 #include "Firestore/core/src/firebase/firestore/util/ordered_code.h"
+#include "Firestore/core/test/firebase/firestore/local/persistence_testing.h"
 #include "absl/strings/string_view.h"
 #include "leveldb/db.h"
 
@@ -38,6 +38,7 @@
 using firebase::firestore::local::LevelDbMutationKey;
 using firebase::firestore::local::LevelDbMutationQueue;
 using firebase::firestore::local::LevelDbPersistence;
+using firebase::firestore::local::LevelDbPersistenceForTesting;
 using firebase::firestore::local::LoadNextBatchIdFromDb;
 using firebase::firestore::local::ReferenceSet;
 using firebase::firestore::model::BatchId;
@@ -77,7 +78,7 @@ @implementation FSTLevelDBMutationQueueTests {
 
 - (void)setUp {
   [super setUp];
-  _db = [FSTPersistenceTestHelpers levelDBPersistence];
+  _db = LevelDbPersistenceForTesting();
   _db->reference_delegate()->AddInMemoryPins(&_additionalReferences);
 
   self.mutationQueue = _db->GetMutationQueueForUser(User("user"));

Firestore/Example/Tests/Local/FSTLevelDBMutationQueueTests.mm

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-#import "Firestore/Example/Tests/Local/FSTPersistenceTestHelpers.h"
 #import "Firestore/Example/Tests/Local/FSTQueryCacheTests.h"
 
 #include "Firestore/core/include/firebase/firestore/timestamp.h"
@@ -27,13 +26,16 @@
 #include "Firestore/core/src/firebase/firestore/model/document_key.h"
 #include "Firestore/core/src/firebase/firestore/model/resource_path.h"
 #include "Firestore/core/src/firebase/firestore/model/snapshot_version.h"
+#include "Firestore/core/test/firebase/firestore/local/persistence_testing.h"
 #include "Firestore/core/test/firebase/firestore/testutil/testutil.h"
 
 namespace core = firebase::firestore::core;
 namespace testutil = firebase::firestore::testutil;
 
 using firebase::Timestamp;
+using firebase::firestore::local::LevelDbDir;
 using firebase::firestore::local::LevelDbPersistence;
+using firebase::firestore::local::LevelDbPersistenceForTesting;
 using firebase::firestore::local::LevelDbQueryCache;
 using firebase::firestore::local::Persistence;
 using firebase::firestore::local::QueryData;
@@ -69,7 +71,7 @@ - (LevelDbQueryCache *)getCache:(Persistence *)persistence {
 - (void)setUp {
   [super setUp];
 
-  _db = [FSTPersistenceTestHelpers levelDBPersistence];
+  _db = LevelDbPersistenceForTesting();
   self.persistence = _db.get();
   self.queryCache = [self getCache:_db.get()];
   self.persistence->reference_delegate()->AddInMemoryPins(&_additionalReferences);
@@ -86,9 +88,9 @@ - (void)testMetadataPersistedAcrossRestarts {
   _db.reset();
   self.persistence = nullptr;
 
-  Path dir = [FSTPersistenceTestHelpers levelDBDir];
+  Path dir = LevelDbDir();
 
-  auto db1 = [FSTPersistenceTestHelpers levelDBPersistenceWithDir:dir];
+  auto db1 = LevelDbPersistenceForTesting(dir);
   LevelDbQueryCache *queryCache = [self getCache:db1.get()];
 
   XCTAssertEqual(0, queryCache->highest_listen_sequence_number());
@@ -111,7 +113,7 @@ QueryData queryData(std::move(query), lastTargetId, minimumSequenceNumber,
   db1->Shutdown();
   db1.reset();
 
-  auto db2 = [FSTPersistenceTestHelpers levelDBPersistenceWithDir:dir];
+  auto db2 = LevelDbPersistenceForTesting(dir);
   db2->Run("verify sequence number", [&] {
     // We should remember the previous sequence number, and the next transaction should
     // have a higher one.

Firestore/Example/Tests/Local/FSTLevelDBQueryCacheTests.mm

@@ -17,21 +17,21 @@
 #include <memory>
 #include <string>
 
-#import "Firestore/Example/Tests/Local/FSTPersistenceTestHelpers.h"
 #import "Firestore/Example/Tests/Local/FSTRemoteDocumentCacheTests.h"
 
 #include "Firestore/core/src/firebase/firestore/local/leveldb_persistence.h"
 #include "Firestore/core/src/firebase/firestore/local/leveldb_remote_document_cache.h"
 #include "Firestore/core/src/firebase/firestore/local/remote_document_cache.h"
-
 #include "Firestore/core/src/firebase/firestore/util/ordered_code.h"
+#include "Firestore/core/test/firebase/firestore/local/persistence_testing.h"
 #include "absl/memory/memory.h"
 #include "leveldb/db.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
 using leveldb::WriteOptions;
 using firebase::firestore::local::LevelDbPersistence;
+using firebase::firestore::local::LevelDbPersistenceForTesting;
 using firebase::firestore::local::LevelDbRemoteDocumentCache;
 using firebase::firestore::local::RemoteDocumentCache;
 using firebase::firestore::util::OrderedCode;
@@ -54,7 +54,7 @@ @implementation FSTLevelDBRemoteDocumentCacheTests {
 
 - (void)setUp {
   [super setUp];
-  _db = [FSTPersistenceTestHelpers levelDBPersistence];
+  _db = LevelDbPersistenceForTesting();
   self.persistence = _db.get();
   HARD_ASSERT(!_cache, "Previous cache not torn down");
   _cache = _db->remote_document_cache();

Firestore/Example/Tests/Local/FSTLevelDBRemoteDocumentCacheTests.mm

@@ -24,16 +24,18 @@
 // TODO(wilhuff): move this to the top once the test filename matches
 #include "Firestore/core/src/firebase/firestore/local/leveldb_transaction.h"
 
-#import "Firestore/Example/Tests/Local/FSTPersistenceTestHelpers.h"
 #import "Firestore/Protos/objc/firestore/local/Mutation.pbobjc.h"
 #import "Firestore/Protos/objc/firestore/local/Target.pbobjc.h"
 
 #include "Firestore/core/src/firebase/firestore/local/leveldb_key.h"
+#include "Firestore/core/src/firebase/firestore/util/path.h"
+#include "Firestore/core/test/firebase/firestore/local/persistence_testing.h"
 #include "absl/strings/string_view.h"
 #include "leveldb/db.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
+using firebase::firestore::local::LevelDbDir;
 using firebase::firestore::local::LevelDbMutationKey;
 using firebase::firestore::local::LevelDbTransaction;
 using firebase::firestore::util::Path;
@@ -55,7 +57,7 @@ - (void)setUp {
   options.error_if_exists = true;
   options.create_if_missing = true;
 
-  Path dir = [FSTPersistenceTestHelpers levelDBDir];
+  Path dir = LevelDbDir();
   DB *db;
   Status status = DB::Open(options, dir.ToUtf8String(), &db);
   XCTAssert(status.ok(), @"Failed to create db: %s", status.ToString().c_str());

Firestore/Example/Tests/Local/FSTLevelDBTransactionTests.mm

@@ -16,15 +16,15 @@
 
 #import "Firestore/Example/Tests/Local/FSTLRUGarbageCollectorTests.h"
 
-#import "Firestore/Example/Tests/Local/FSTPersistenceTestHelpers.h"
-
 #include "Firestore/core/src/firebase/firestore/local/memory_lru_reference_delegate.h"
 #include "Firestore/core/src/firebase/firestore/local/memory_persistence.h"
 #include "Firestore/core/src/firebase/firestore/model/document_key.h"
+#include "Firestore/core/test/firebase/firestore/local/persistence_testing.h"
 
 using firebase::firestore::model::DocumentKey;
 using firebase::firestore::local::LruParams;
 using firebase::firestore::local::MemoryLruReferenceDelegate;
+using firebase::firestore::local::MemoryPersistenceWithLruGcForTesting;
 using firebase::firestore::local::Persistence;
 
 NS_ASSUME_NONNULL_BEGIN
@@ -35,7 +35,7 @@ @interface FSTMemoryLRUGarbageCollectionTests : FSTLRUGarbageCollectorTests
 @implementation FSTMemoryLRUGarbageCollectionTests
 
 - (std::unique_ptr<Persistence>)newPersistenceWithLruParams:(LruParams)lruParams {
-  return [FSTPersistenceTestHelpers lruMemoryPersistenceWithLruParams:lruParams];
+  return MemoryPersistenceWithLruGcForTesting(lruParams);
 }
 
 - (BOOL)sentinelExists:(const DocumentKey &)key {

Firestore/Example/Tests/Local/FSTMemoryLRUGarbageCollectorTests.mm

@@ -16,13 +16,13 @@
 
 #import "Firestore/Example/Tests/Local/FSTLocalStoreTests.h"
 
-#import "Firestore/Example/Tests/Local/FSTPersistenceTestHelpers.h"
-
 #include "Firestore/core/src/firebase/firestore/local/memory_persistence.h"
 #include "Firestore/core/src/firebase/firestore/local/reference_delegate.h"
+#include "Firestore/core/test/firebase/firestore/local/persistence_testing.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
+using firebase::firestore::local::MemoryPersistenceWithEagerGcForTesting;
 using firebase::firestore::local::Persistence;
 
 /**
@@ -36,7 +36,7 @@ @interface FSTMemoryLocalStoreTests : FSTLocalStoreTests
 @implementation FSTMemoryLocalStoreTests
 
 - (std::unique_ptr<Persistence>)persistence {
-  return [FSTPersistenceTestHelpers eagerGCMemoryPersistence];
+  return MemoryPersistenceWithEagerGcForTesting();
 }
 
 - (BOOL)gcIsEager {