Rest of review comments

Author: paulb777

FirebaseRemoteConfig/Sources/RCNConfigSettings.m

@@ -151,7 +151,6 @@ - (void)setLastETag:(NSString *)lastETag {
 }
 
 - (void)setLastETagUpdateTime:(NSTimeInterval)lastETagUpdateTime {
-  NSLog(@"setter: %f", lastETagUpdateTime);
   [_userDefaultsManager setLastETagUpdateTime:lastETagUpdateTime];
 }
 

FirebaseRemoteConfig/SwiftNew/ConfigDBManager.swift

@@ -323,7 +323,7 @@ open class ConfigDBManager: NSObject {
   @objc public
   func deleteRecord(withBundleIdentifier bundleIdentifier: String,
                     namespace: String) {
-    let sql = "DELETE FROM fetch_metadata WHERE bundle_identifier = ? and namespace = ?"
+    let sql = "DELETE FROM fetch_metadata_v2 WHERE bundle_identifier = ? and namespace = ?"
     let params = [bundleIdentifier, namespace]
     Task {
       await self.databaseActor.executeQuery(sql, withParams: params)

FirebaseRemoteConfig/SwiftNew/DatabaseActor.swift

@@ -85,7 +85,7 @@ actor DatabaseActor {
 
   func insertMetadataTable(withValues columnNameToValue: [String: Any]) -> Bool {
     let sql = """
-    INSERT into fetch_metadata (\
+    INSERT into fetch_metadata_v2 (\
       bundle_identifier, \
       namespace, \
       fetch_time, \
@@ -333,12 +333,12 @@ actor DatabaseActor {
     var sql: String
     switch option {
     case .applyTime:
-      sql = "UPDATE fetch_metadata SET last_apply_time = ? WHERE namespace = ?"
+      sql = "UPDATE fetch_metadata_v2 SET last_apply_time = ? WHERE namespace = ?"
     case .defaultTime:
-      sql = "UPDATE fetch_metadata SET last_set_defaults_time = ? WHERE namespace = ?"
+      sql = "UPDATE fetch_metadata_v2 SET last_set_defaults_time = ? WHERE namespace = ?"
     case .fetchStatus:
       sql =
-        "UPDATE fetch_metadata SET last_fetch_status = ?, last_fetch_error = ? WHERE namespace = ?"
+        "UPDATE fetch_metadata_v2 SET last_fetch_status = ?, last_fetch_error = ? WHERE namespace = ?"
     }
 
     var statement: OpaquePointer? = nil
@@ -389,7 +389,7 @@ actor DatabaseActor {
       last_fetch_error, \
       last_apply_time, \
       last_set_defaults_time \
-    FROM fetch_metadata \
+    FROM fetch_metadata_v2 \
     WHERE bundle_identifier = ? AND namespace = ?
     """
     var statement: OpaquePointer?
@@ -703,7 +703,7 @@ actor DatabaseActor {
     """
 
     let createMetadata = """
-    CREATE TABLE IF NOT EXISTS fetch_metadata (
+    CREATE TABLE IF NOT EXISTS fetch_metadata_v2 (
       _id INTEGER PRIMARY KEY,
       bundle_identifier TEXT,
       namespace TEXT,