Change the para of WithAddedFilters function (#10342)

Author: cherylEnkidu

Firestore/core/src/core/composite_filter.cc

@@ -114,11 +114,10 @@ bool CompositeFilter::Rep::Equals(const Filter::Rep& other) const {
 }
 
 CompositeFilter CompositeFilter::WithAddedFilters(
-    std::vector<core::Filter>&& other_filters) {
+    const std::vector<core::Filter>& other_filters) {
   std::vector<Filter> merged_filters(filters());
-  merged_filters.insert(merged_filters.end(),
-                        std::make_move_iterator(other_filters.begin()),
-                        std::make_move_iterator(other_filters.end()));
+  merged_filters.insert(merged_filters.end(), other_filters.begin(),
+                        other_filters.end());
   return CompositeFilter::Create(std::move(merged_filters), op());
 }
 

Firestore/core/src/core/composite_filter.h

@@ -84,7 +84,8 @@ class CompositeFilter : public Filter {
    * Returns a new composite filter that contains all filter from `this`
    * plus all the given filters.
    */
-  CompositeFilter WithAddedFilters(std::vector<core::Filter>&& other_filters);
+  CompositeFilter WithAddedFilters(
+      const std::vector<core::Filter>& other_filters);
 
  private:
   class Rep : public Filter::Rep {

Firestore/core/src/util/logic_utils.cc

@@ -195,7 +195,7 @@ Filter LogicUtils::ApplyDistribution(CompositeFilter&& lhs,
 
   // Case 1 is a merge.
   if (lhs.IsConjunction() && rhs.IsConjunction()) {
-    return lhs.WithAddedFilters(std::vector<Filter>(rhs.filters()));
+    return lhs.WithAddedFilters(rhs.filters());
   }
 
   // Case 2,3,4 all have at least one side (lhs or rhs) that is a disjunction.