Fix FIRFunctions.useEmulatorWithHost scheme (#7545)

Author: samtstern

Functions/CHANGELOG.md

@@ -1,3 +1,6 @@
+# Unreleased
+- [fixed] Fixed missing "http://" prefix when using Functions with the emulator. (#7537, #7538)
+
 # v7.2.0
 - [added] Made emulator connection API consistent between Auth, Database, Firestore, and Functions (#5916).
 

Functions/Example/Tests/FIRFunctionsTests.m

@@ -60,7 +60,14 @@ - (void)testRegionWithEmulator {
   [_functionsCustomDomain useEmulatorWithHost:@"localhost" port:5005];
   NSLog(@"%@", _functionsCustomDomain.emulatorOrigin);
   NSString *url = [_functionsCustomDomain URLWithName:@"my-endpoint"];
-  XCTAssertEqualObjects(@"localhost:5005/my-project/my-region/my-endpoint", url);
+  XCTAssertEqualObjects(@"http://localhost:5005/my-project/my-region/my-endpoint", url);
+}
+
+- (void)testRegionWithEmulatorWithScheme {
+  [_functionsCustomDomain useEmulatorWithHost:@"http://localhost" port:5005];
+  NSLog(@"%@", _functionsCustomDomain.emulatorOrigin);
+  NSString *url = [_functionsCustomDomain URLWithName:@"my-endpoint"];
+  XCTAssertEqualObjects(@"http://localhost:5005/my-project/my-region/my-endpoint", url);
 }
 
 - (void)testCustomDomain {
@@ -71,12 +78,12 @@ - (void)testCustomDomain {
 - (void)testCustomDomainWithEmulator {
   [_functionsCustomDomain useEmulatorWithHost:@"localhost" port:5005];
   NSString *url = [_functionsCustomDomain URLWithName:@"my-endpoint"];
-  XCTAssertEqualObjects(@"localhost:5005/my-project/my-region/my-endpoint", url);
+  XCTAssertEqualObjects(@"http://localhost:5005/my-project/my-region/my-endpoint", url);
 }
 
 - (void)testSetEmulatorSettings {
   [_functions useEmulatorWithHost:@"localhost" port:1000];
-  XCTAssertEqualObjects(@"localhost:1000", _functions.emulatorOrigin);
+  XCTAssertEqualObjects(@"http://localhost:1000", _functions.emulatorOrigin);
 }
 
 @end

Functions/FirebaseFunctions/FIRFunctions.m

@@ -149,12 +149,13 @@ - (instancetype)initWithProjectID:(NSString *)projectID
 }
 
 - (void)useLocalhost {
-  [self useEmulatorWithHost:@"http://localhost" port:5005];
+  [self useEmulatorWithHost:@"localhost" port:5005];
 }
 
 - (void)useEmulatorWithHost:(NSString *)host port:(NSInteger)port {
   NSAssert(host.length > 0, @"Cannot connect to nil or empty host");
-  NSString *origin = [NSString stringWithFormat:@"%@:%li", host, (long)port];
+  NSString *prefix = [host hasPrefix:@"http"] ? @"" : @"http://";
+  NSString *origin = [NSString stringWithFormat:@"%@%@:%li", prefix, host, (long)port];
   _emulatorOrigin = origin;
 }