make internal impl of Order public

Author: cherylEnkidu

Firestore/Swift/Source/SwiftAPI/Pipeline/Expressions/Expression.swift

@@ -826,14 +826,14 @@ public protocol Expression: Sendable {
 
   /// Creates an expression that checks if a string (from `self`) contains a specified substring
   /// from an expression (case-sensitive).
-  /// Assumes `self` evaluates to a string, and `expr` evaluates to a string.
+  /// Assumes `self` evaluates to a string, and `expression` evaluates to a string.
   ///
   /// ```swift
   /// // Check if the "message" field contains the value of the "keyword" field.
   /// Field("message").stringContains(Field("keyword"))
   /// ```
   ///
-  /// - Parameter expr: An `Expression` (evaluating to a string) representing the substring to
+  /// - Parameter expression: An `Expression` (evaluating to a string) representing the substring to
   /// search for.
   /// - Returns: A new `BooleanExpr` representing the "str_contains" comparison.
   func stringContains(_ expression: Expression) -> BooleanExpression

Firestore/Swift/Source/SwiftAPI/Pipeline/Expressions/FunctionExpressions/ConditionalExpression.swift

@@ -38,7 +38,7 @@ public class ConditionalExpression: FunctionExpression, @unchecked Sendable {
   /// Creates a new `ConditionalExpression`.
   ///
   /// - Parameters:
-  ///   - expr: The `BooleanExpression` to evaluate.
+  ///   - expression: The `BooleanExpression` to evaluate.
   ///   - thenExpression: The `Expression` to evaluate if the boolean expression is `true`.
   ///   - elseExpression: The `Expression` to evaluate if the boolean expression is `false`.
   public init(_ expr: BooleanExpression,

Firestore/Swift/Source/SwiftAPI/Pipeline/Ordering.swift

@@ -15,20 +15,20 @@
  */
 
 public struct Ordering: @unchecked Sendable {
-  let expr: Expression
-  let direction: Direction
+  public let expression: Expression
+  public let direction: Direction
   let bridge: OrderingBridge
 
   init(expression: Expression, direction: Direction) {
-    expr = expression
+    self.expression = expression
     self.direction = direction
     bridge = OrderingBridge(expr: expression.toBridge(), direction: direction.rawValue)
   }
 }
 
-struct Direction: Sendable, Equatable, Hashable {
+public struct Direction: Sendable, Equatable, Hashable {
   let kind: Kind
-  let rawValue: String
+  public let rawValue: String
 
   enum Kind: String {
     case ascending

Firestore/Swift/Source/SwiftAPI/Pipeline/Pipeline.swift

@@ -453,7 +453,7 @@ public struct Pipeline: @unchecked Sendable {
   /// Fully overwrites document fields with those from a nested map identified by an `Expr`.
   ///
   /// "Promotes" a map value (dictionary) from a field to become the new root document.
-  /// Each key-value pair from the map specified by `expr` becomes a field-value pair
+  /// Each key-value pair from the map specified by `expression` becomes a field-value pair
   /// in the output document, discarding original document fields.
   ///
   /// ```swift
@@ -468,7 +468,7 @@ public struct Pipeline: @unchecked Sendable {
   /// // Output document would be: { "name": "Alex", "age": 30 }
   /// ```
   ///
-  /// - Parameter expr: The `Expr` (typically a `Field`) that resolves to the nested map.
+  /// - Parameter expression: The `Expr` (typically a `Field`) that resolves to the nested map.
   /// - Returns: A new `Pipeline` object with this stage appended.
   public func replace(with expr: Expression) -> Pipeline {
     return Pipeline(stages: stages + [ReplaceWith(expr: expr)], db: db)