hide equivalent

Author: cherylEnkidu

Firestore/Swift/Source/ExpressionImplementation.swift

@@ -343,6 +343,17 @@ extension Expression {
   func stringReplace(_ find: Expression, with replace: Expression) -> FunctionExpression {
     return FunctionExpression("string_replace", [self, find, replace])
   }
+  
+  // MARK: Equivalence Operations
+
+  /// Creates a `BooleanExpr` that returns `true` if this expression is equivalent
+  /// to the given value.
+  ///
+  /// - Parameter other: The value to compare against.
+  /// - Returns: A `BooleanExpr` that can be used in `where` clauses.
+  func equivalent(_ other: Sendable) -> BooleanExpression {
+    return BooleanExpression("equivalent", [self, Helper.sendableToExpr(other)])
+  }
 }
 
 public extension Expression {
@@ -889,12 +900,6 @@ public extension Expression {
     return Ordering(expression: self, direction: .descending)
   }
 
-  // MARK: Equivalence Operations
-
-  func equivalent(_ other: Sendable) -> BooleanExpression {
-    return BooleanExpression("equivalent", [self, Helper.sendableToExpr(other)])
-  }
-
   func concat(_ values: [Sendable]) -> FunctionExpression {
     let exprs = [self] + values.map { Helper.sendableToExpr($0) }
     return FunctionExpression("concat", exprs)

Firestore/Swift/Source/SwiftAPI/Pipeline/Expressions/Expression.swift

@@ -1556,15 +1556,6 @@ public protocol Expression: Sendable {
   /// - Returns: A new `Ordering` instance for descending sorting.
   func descending() -> Ordering
 
-  // MARK: Equivalence Operations
-
-  /// Creates a `BooleanExpr` that returns `true` if this expression is equivalent
-  /// to the given value.
-  ///
-  /// - Parameter other: The value to compare against.
-  /// - Returns: A `BooleanExpr` that can be used in `where` clauses.
-  func equivalent(_ other: Sendable) -> BooleanExpression
-
   /// Creates an expression that concatenates multiple sequenceable types together.
   ///
   /// ```swift

Firestore/Swift/Tests/Integration/PipelineTests.swift

@@ -1677,24 +1677,24 @@ class PipelineIntegrationTests: FSTIntegrationTestCase {
     TestHelper.compare(snapshot: snapshot, expected: expectedResults, enforceOrder: true)
   }
 
-  func testEquivalentWorks() async throws {
-    let collRef = collectionRef(withDocuments: [
-      "doc1": ["value": 1, "value2": 1],
-      "doc2": ["value": 1, "value2": 2],
-      "doc3": ["value": NSNull(), "value2": NSNull()],
-      "doc4": ["value": NSNull(), "value2": 1],
-      "doc5": ["value": Double.nan, "value2": Double.nan],
-      "doc6": ["value": Double.nan, "value2": 1],
-    ])
-    let db = collRef.firestore
-
-    let pipeline = db.pipeline()
-      .collection(collRef.path)
-      .where(Field("value").equivalent(Field("value2")))
-    let snapshot = try await pipeline.execute()
-
-    XCTAssertEqual(snapshot.results.count, 3)
-  }
+//  func testEquivalentWorks() async throws {
+//    let collRef = collectionRef(withDocuments: [
+//      "doc1": ["value": 1, "value2": 1],
+//      "doc2": ["value": 1, "value2": 2],
+//      "doc3": ["value": NSNull(), "value2": NSNull()],
+//      "doc4": ["value": NSNull(), "value2": 1],
+//      "doc5": ["value": Double.nan, "value2": Double.nan],
+//      "doc6": ["value": Double.nan, "value2": 1],
+//    ])
+//    let db = collRef.firestore
+//
+//    let pipeline = db.pipeline()
+//      .collection(collRef.path)
+//      .where(Field("value").equivalent(Field("value2")))
+//    let snapshot = try await pipeline.execute()
+//
+//    XCTAssertEqual(snapshot.results.count, 3)
+//  }
 
   func testInWorks() async throws {
     let collRef = collectionRef(withDocuments: bookDocs)