Skip to content

Commit 46f0421

Browse files
authored
[Binary] Add missing values to Info.plist generator (#12413)
1 parent 1ed6d66 commit 46f0421

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

ReleaseTooling/Sources/ZipBuilder/CarthageUtils.swift

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,10 +250,15 @@ extension CarthageUtils {
250250
withVersion version: String,
251251
to location: URL) {
252252
let ver = version.components(separatedBy: "-")[0] // remove any version suffix.
253+
254+
// TODO(paulb777): Does MinimumOSVersion or anything else need
255+
// to be adapted for other platforms?
253256
let plist: [String: String] = ["CFBundleIdentifier": "com.firebase.Firebase-\(name)",
254257
"CFBundleInfoDictionaryVersion": "6.0",
255258
"CFBundlePackageType": "FMWK",
256259
"CFBundleVersion": ver,
260+
"CFBundleShortVersionString": ver,
261+
"MinimumOSVersion": Platform.iOS.minimumVersion,
257262
"DTSDKName": "iphonesimulator11.2",
258263
"CFBundleExecutable": name,
259264
"CFBundleName": name]

0 commit comments

Comments
 (0)