Skip to content

Commit 4b26b31

Browse files
authored
[Firestore] Follow-up review items from #11954 (#11970)
1 parent 3e4b721 commit 4b26b31

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

FirebaseDatabase/Swift/Sources/SPMSwiftHeaderWorkaround.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717

1818
// This is a trick to force generate a `FirebaseDatabase-Swift.h`
1919
// header that re-exports `FirebaseDatabaseInternal` for Objective-C
20-
// clients. It is important for the below code to reference a Remote
21-
// Config symbol defined in Objective-C as that will import the symbol's
20+
// clients. It is important for the below code to reference a Database
21+
// symbol defined in Objective-C as that will import the symbol's
2222
// module (`FirebaseDatabaseInternal`) in the generated header. This
23-
// allows Objective-C clients to import Remote Config's Objective-C API
23+
// allows Objective-C clients to import Database's Objective-C API
2424
// using `@import FirebaseDatabase;`. This API is not needed for Swift
2525
// clients and is therefore unavailable in a Swift context.
2626
@available(*, unavailable)

FirebaseInAppMessaging/Swift/Source/SPMSwiftHeaderWorkaround.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717

1818
// This is a trick to force generate a `FirebaseInAppMessaging-Swift.h`
1919
// header that re-exports `FirebaseInAppMessagingInternal` for Objective-C
20-
// clients. It is important for the below code to reference a Remote
21-
// Config symbol defined in Objective-C as that will import the symbol's
20+
// clients. It is important for the below code to reference an In App
21+
// Messaging symbol defined in Objective-C as that will import the symbol's
2222
// module (`FirebaseInAppMessagingInternal`) in the generated header. This
23-
// allows Objective-C clients to import Remote Config's Objective-C API
23+
// allows Objective-C clients to import In App Messaging's Objective-C API
2424
// using `@import FirebaseInAppMessaging;`. This API is not needed for Swift
2525
// clients and is therefore unavailable in a Swift context.
2626
@available(*, unavailable)

Firestore/Example/Podfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ end
5656
# required.
5757
def configure_local_pods()
5858
# Firestore is always local; that's what's under development here.
59-
pod 'FirebaseFirestore', :path => '../../'
59+
pod 'FirebaseFirestore', :path => '../..'
6060

6161
# FirebaseCore must always be a local pod so that CI builds that make changes
6262
# to its podspec can still function. See Firestore-*-xcodebuild in

Firestore/Swift/Source/SwiftHeaderWorkaround.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020

2121
// This is a trick to force generate a `FirebaseFirestore-Swift.h`
2222
// header that re-exports `FirebaseFirestoreInternal` for Objective-C
23-
// clients. It is important for the below code to reference a Remote
24-
// Config symbol defined in Objective-C as that will import the symbol's
23+
// clients. It is important for the below code to reference a Firestore
24+
// symbol defined in Objective-C as that will import the symbol's
2525
// module (`FirebaseFirestoreInternal`) in the generated header. This
2626
// allows Objective-C clients to import Firestore's Objective-C API
2727
// using `@import FirebaseFirestore;`. This API is not needed for Swift

ReleaseTooling/Sources/ZipBuilder/ModuleMapBuilder.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ struct ModuleMapBuilder {
4747
4848
"""
4949

50-
if module == "FirebaseFirestore" {
50+
if module == "FirebaseFirestoreInternal" {
5151
content += """
5252
link framework "BoringSSL-GRPC"
5353
link framework "gRPC-Core"

0 commit comments

Comments
 (0)