Add SPM ObjC import test (#6191)

Author: paulb777

Package.swift

@@ -109,7 +109,7 @@ let package = Package(
   ],
   targets: [
     .testTarget(
-      name: "firebase-test",
+      name: "swift-test",
       dependencies: [
         "FirebaseAuth",
         "FirebaseABTesting",
@@ -136,7 +136,25 @@ let package = Package(
         "GoogleUtilities_Reachability",
         "GoogleUtilities_UserDefaults",
         .product(name: "nanopb", package: "nanopb"),
-      ]
+      ],
+      path: "SwiftPMTests/swift-test"
+    ),
+    .testTarget(
+      name: "objc-import-test",
+      dependencies: [
+        "FirebaseAuth",
+        "FirebaseABTesting",
+        "FirebaseFunctions",
+        "Firebase",
+        "FirebaseCrashlytics",
+        "FirebaseCore",
+        "FirebaseDatabase",
+        "FirebaseFirestore",
+        "FirebaseInstallations",
+        "FirebaseRemoteConfig",
+        "FirebaseStorage",
+      ],
+      path: "SwiftPMTests/objc-import-test"
     ),
     .target(
       name: "GoogleUtilities_AppDelegateSwizzler",

SwiftPMTests/objc-import-test/objc-header.m

@@ -0,0 +1,37 @@
+// Copyright 2020 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#import "FirebaseABTesting/FirebaseABTesting.h"
+#import "FirebaseAuth/FirebaseAuth.h"
+//#import "FirebaseFunctions/FirebaseFunctions.h"
+#import "Firebase.h"
+#import "FirebaseCore/FirebaseCore.h"
+#import "FirebaseCrashlytics/FirebaseCrashlytics.h"
+#import "FirebaseDatabase/FirebaseDatabase.h"
+//#import "FirebaseFirestore/FirebaseFirestore."
+#import "FirebaseInstallations/FirebaseInstallations.h"
+#import "FirebaseRemoteConfig/FirebaseRemoteConfig.h"
+#import "FirebaseStorage/FirebaseStorage.h"
+
+#import <FirebaseABTesting/FirebaseABTesting.h>
+#import <FirebaseAuth/FirebaseAuth.h>
+//#import <FirebaseFunctions/FirebaseFunctions.h>
+#import <Firebase.h>
+#import <FirebaseCore/FirebaseCore.h>
+#import <FirebaseCrashlytics/FirebaseCrashlytics.h>
+#import <FirebaseDatabase/FirebaseDatabase.h>
+//#import <FirebaseFirestore/FirebaseFirestore.>
+#import <FirebaseInstallations/FirebaseInstallations.h>
+#import <FirebaseRemoteConfig/FirebaseRemoteConfig.h>
+#import <FirebaseStorage/FirebaseStorage.h>

SwiftPMTests/objc-import-test/objc-module.m

@@ -0,0 +1,25 @@
+// Copyright 2020 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+@import FirebaseAuth;
+@import FirebaseABTesting;
+@import FirebaseFunctions;
+@import Firebase;
+@import FirebaseCrashlytics;
+@import FirebaseCore;
+@import FirebaseDatabase;
+@import FirebaseFirestore;
+@import FirebaseInstallations;
+@import FirebaseRemoteConfig;
+@import FirebaseStorage;

Tests/firebase-test/main.swift renamed to SwiftPMTests/swift-test/main.swift

@@ -29,7 +29,8 @@ let skipDirPatterns = ["/Sample/", "/Pods/", "FirebaseStorage/Tests/Integration"
                        "Example/InstanceID/App", "SymbolCollisionTest/", "/gen/",
                        "CocoapodsIntegrationTest/"] +
   [
-    "CoreOnly/Sources", // Skip Firebase.h
+    "CoreOnly/Sources", // Skip Firebase.h.
+    "SwiftPMTests", // The SwiftPM imports test module imports.
   ] +
 
   // The following are temporary skips pending working through a first pass of the repo:

scripts/check_imports.swift

@@ -30,11 +30,10 @@ function exit_with_error {
 git grep "${options[@]}" \
   -- ':(exclude,glob)**/Example/**' ':(exclude,glob)**/Sample/**' \
      ':(exclude)FirebaseAuth/Sources/Backend/FIRAuthBackend.m' \
-     ':(exclude)FirebaseABTesting/Sources/Private/FirebaseABTestingInternal.h' \
-     ':(exclude)FirebaseCore/Sources/Private/FirebaseCoreInternal.h' \
      ':(exclude)FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h' \
      ':(exclude,glob)Crashlytics/**' \
      ':(exclude,glob)FirebaseStorage/**' \
+     ':(exclude,glob)SwiftPMTests/**' \
      ':(exclude)Functions/FirebaseFunctions/FIRFunctions.m' \
      ':(exclude)GoogleDataTransport/GDTCORLibrary/Internal/GoogleDataTransportInternal.h' \
      ':(exclude)GoogleUtilities/NSData+zlib/Private/GULNSDataInternal.h' \