Skip to content

Commit 526a1ad

Browse files
collinjacksonrenkelvin
authored andcommitted
fix for signInProvider property of FIRAuthTokenResult returning nil (#3446)
* fix for signInProvider * Add a test * Use constant
1 parent a69b8d2 commit 526a1ad

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Example/Auth/Tests/FIRUserTests.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1072,6 +1072,7 @@ - (void)testGetIDTokenResultSuccess {
10721072
XCTAssertTrue(tokenResult.authDate && [tokenResult.authDate isKindOfClass:[NSDate class]]);
10731073
XCTAssertTrue(tokenResult.expirationDate &&
10741074
[tokenResult.expirationDate isKindOfClass:[NSDate class]]);
1075+
XCTAssertEqualObjects(tokenResult.signInProvider, FIREmailAuthProviderID);
10751076
XCTAssertTrue(tokenResult.claims && [tokenResult.claims isKindOfClass:[NSDictionary class]]);
10761077
[expectation fulfill];
10771078
}];

Firebase/Auth/Source/User/FIRUser.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,7 @@ - (nullable FIRAuthTokenResult *)parseIDToken:(NSString *)token error:(NSError *
938938
expirationDate:expDate
939939
authDate:authDate
940940
issuedAtDate:issuedDate
941-
signInProvider:tokenPayloadDictionary[@"sign_in_provider"]
941+
signInProvider:tokenPayloadDictionary[@"firebase"][@"sign_in_provider"]
942942
claims:tokenPayloadDictionary];
943943
return result;
944944
}

0 commit comments

Comments
 (0)