Fix memory error

Author: cherylEnkidu

Firestore/Swift/Tests/Integration/PipelineTests.swift

@@ -1508,4 +1508,57 @@ class PipelineIntegrationTests: FSTIntegrationTestCase {
 
     TestHelper.compare(pipelineSnapshot: snapshot, expected: expectedResults, enforceOrder: false)
   }
+  
+  func testFindNearest() async throws {
+      let collRef = collectionRef(withDocuments: bookDocs)
+      let db = collRef.firestore
+
+      let measures: [DistanceMeasure] = [.euclidean, .dotProduct, .cosine]
+      let expectedResults: [[String: Sendable]] = [
+        ["title": "The Hitchhiker's Guide to the Galaxy"],
+        ["title": "One Hundred Years of Solitude"],
+        ["title": "The Handmaid's Tale"],
+      ]
+
+      for measure in measures {
+        let pipeline = db.pipeline()
+          .collection(collRef.path)
+          .findNearest(
+            field: Field("embedding"),
+            vectorValue: [10, 1, 3, 1, 2, 1, 1, 1, 1, 1],
+            distanceMeasure: measure, limit: 3
+          )
+          .select("title")
+        let snapshot = try await pipeline.execute()
+        TestHelper.compare(pipelineSnapshot: snapshot, expected: expectedResults, enforceOrder: true)
+      }
+    }
+
+    func testFindNearestWithDistance() async throws {
+      let collRef = collectionRef(withDocuments: bookDocs)
+      let db = collRef.firestore
+
+      let expectedResults: [[String: Sendable]] = [
+        [
+          "title": "The Hitchhiker's Guide to the Galaxy",
+          "computedDistance": 1.0,
+        ],
+        [
+          "title": "One Hundred Years of Solitude",
+          "computedDistance": 12.041594578792296,
+        ],
+      ]
+
+      let pipeline = db.pipeline()
+        .collection(collRef.path)
+        .findNearest(
+          field: Field("embedding"),
+          vectorValue: [10, 1, 2, 1, 1, 1, 1, 1, 1, 1],
+          distanceMeasure: .euclidean, limit: 2,
+          distanceField: "computedDistance"
+        )
+        .select("title", "computedDistance")
+      let snapshot = try await pipeline.execute()
+      TestHelper.compare(pipelineSnapshot: snapshot, expected: expectedResults, enforceOrder: false)
+    }
 }

Firestore/core/src/api/stages.cc

@@ -28,6 +28,8 @@ namespace firebase {
 namespace firestore {
 namespace api {
 
+using model::DeepClone;
+
 google_firestore_v1_Pipeline_Stage CollectionSource::to_proto() const {
   google_firestore_v1_Pipeline_Stage result;
 
@@ -191,7 +193,7 @@ google_firestore_v1_Pipeline_Stage FindNearestStage::to_proto() const {
   result.args_count = 3;
   result.args = nanopb::MakeArray<google_firestore_v1_Value>(3);
   result.args[0] = property_->to_proto();
-  result.args[1] = *vector_;
+  result.args[1] = *DeepClone(*vector_).release();
   result.args[2] = distance_measure_.proto();
 
   nanopb::SetRepeatedField(
@@ -200,7 +202,7 @@ google_firestore_v1_Pipeline_Stage FindNearestStage::to_proto() const {
                          nanopb::SharedMessage<google_firestore_v1_Value>>&
              entry) {
         return _google_firestore_v1_Pipeline_Stage_OptionsEntry{
-            nanopb::MakeBytesArray(entry.first), *entry.second};
+            nanopb::MakeBytesArray(entry.first), *DeepClone(*entry.second).release()};
       });
 
   return result;