Skip to content

Commit 534ea5c

Browse files
committed
review
1 parent e4a895c commit 534ea5c

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ typedef void (^FIRRemoteConfigUpdateCompletion)(FIRRemoteConfigUpdate *_Nullable
356356
userDefaults:(nullable NSUserDefaults *)userDefaults
357357
analytics:(nullable id<FIRAnalyticsInterop>)analytics;
358358

359-
/// Register RolloutsStateSubcriber to FIRRemoteConfig instance
359+
/// Register `FIRRolloutsStateSubscriber` to `FIRRemoteConfig` instance
360360
- (void)addRemoteConfigInteropSubscriber:(id<FIRRolloutsStateSubscriber> _Nonnull)subscriber;
361361

362362
@end

FirebaseRemoteConfig/SwiftNew/RemoteConfigComponent.swift

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ extension RemoteConfigComponent: RemoteConfigProvider {
6565
return nil
6666
}
6767

68+
// Validate the required information is available.
6869
let errorPropertyName = if app.options.googleAppID.isEmpty {
6970
"googleAppID"
7071
} else if app.options.gcmSenderID.isEmpty {
@@ -74,13 +75,9 @@ extension RemoteConfigComponent: RemoteConfigProvider {
7475
} else { nil as String? }
7576

7677
if let errorPropertyName {
77-
NSException.raise(
78-
NSExceptionName("com.firebase.config"),
79-
format: "Firebase Remote Config is missing the required %@ property from the " +
80-
"configured FirebaseApp and will not be able to function properly. " +
81-
"Please fix this issue to ensure that Firebase is correctly configured.",
82-
arguments: getVaList([errorPropertyName])
83-
)
78+
fatalError("Firebase Remote Config is missing the required \(errorPropertyName) property from the " +
79+
"configured FirebaseApp and will not be able to function properly. " +
80+
"Please fix this issue to ensure that Firebase is correctly configured.")
8481
}
8582

8683
instancesLock.lock()

0 commit comments

Comments
 (0)