Skip to content

Commit 54747a0

Browse files
authored
Fix CI issues from changing interop pod version requirements (#4979)
1 parent 1fb6a77 commit 54747a0

File tree

9 files changed

+23
-3
lines changed

9 files changed

+23
-3
lines changed

CocoapodsIntegrationTest/TestEnvironments/Cocoapods1_6_1_frameworks/Podfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ target 'CocoapodsIntegrationTest' do
88
pod 'FirebaseCoreDiagnostics', :path => '../'
99
pod 'FirebaseCoreDiagnosticsInterop', :path => '../'
1010
pod 'FirebaseCrashlytics', :path => '../'
11+
pod 'FirebaseAnalyticsInterop', :path => '../'
1112
pod 'FirebaseAuth', :path => '../'
13+
pod 'FirebaseAuthInterop', :path => '../'
1214
pod 'FirebaseDatabase', :path => '../'
1315
pod 'FirebaseDynamicLinks', :path => '../'
1416
pod 'FirebaseFirestore', :path => '../'

CocoapodsIntegrationTest/TestEnvironments/Cocoapods1_6_1_staticLibs/Podfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ target 'CocoapodsIntegrationTest' do
66
pod 'FirebaseCoreDiagnostics', :path => '../'
77
pod 'FirebaseCoreDiagnosticsInterop', :path => '../'
88
pod 'FirebaseCrashlytics', :path => '../'
9+
pod 'FirebaseAnalyticsInterop', :path => '../'
910
pod 'FirebaseAuth', :path => '../'
11+
pod 'FirebaseAuthInterop', :path => '../'
1012
pod 'FirebaseDatabase', :path => '../'
1113
pod 'FirebaseDynamicLinks', :path => '../'
1214
pod 'FirebaseFirestore', :path => '../'

CocoapodsIntegrationTest/TestEnvironments/Cocoapods1_7_0_frameworks/Podfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ target 'CocoapodsIntegrationTest' do
88
pod 'FirebaseCoreDiagnostics', :path => '../'
99
pod 'FirebaseCoreDiagnosticsInterop', :path => '../'
1010
pod 'FirebaseCrashlytics', :path => '../'
11+
pod 'FirebaseAnalyticsInterop', :path => '../'
1112
pod 'FirebaseAuth', :path => '../'
13+
pod 'FirebaseAuthInterop', :path => '../'
1214
pod 'FirebaseDatabase', :path => '../'
1315
pod 'FirebaseDynamicLinks', :path => '../'
1416
pod 'FirebaseFirestore', :path => '../'

CocoapodsIntegrationTest/TestEnvironments/Cocoapods1_7_0_multiprojects_frameworks/Podfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ target 'CocoapodsIntegrationTest' do
99
pod 'FirebaseCoreDiagnostics', :path => '../'
1010
pod 'FirebaseCoreDiagnosticsInterop', :path => '../'
1111
pod 'FirebaseCrashlytics', :path => '../'
12+
pod 'FirebaseAnalyticsInterop', :path => '../'
1213
pod 'FirebaseAuth', :path => '../'
14+
pod 'FirebaseAuthInterop', :path => '../'
1315
pod 'FirebaseDatabase', :path => '../'
1416
pod 'FirebaseDynamicLinks', :path => '../'
1517
pod 'FirebaseFirestore', :path => '../'

CocoapodsIntegrationTest/TestEnvironments/Cocoapods1_7_0_multiprojects_staticLibs/Podfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ target 'CocoapodsIntegrationTest' do
66
pod 'FirebaseCoreDiagnostics', :path => '../'
77
pod 'FirebaseCoreDiagnosticsInterop', :path => '../'
88
pod 'FirebaseCrashlytics', :path => '../'
9+
pod 'FirebaseAnalyticsInterop', :path => '../'
910
pod 'FirebaseAuth', :path => '../'
11+
pod 'FirebaseAuthInterop', :path => '../'
1012
pod 'FirebaseDatabase', :path => '../'
1113
pod 'FirebaseDynamicLinks', :path => '../'
1214
pod 'FirebaseFirestore', :path => '../'

CocoapodsIntegrationTest/TestEnvironments/Cocoapods1_7_0_staticLibs/Podfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ target 'CocoapodsIntegrationTest' do
66
pod 'FirebaseCoreDiagnostics', :path => '../'
77
pod 'FirebaseCoreDiagnosticsInterop', :path => '../'
88
pod 'FirebaseCrashlytics', :path => '../'
9+
pod 'FirebaseAnalyticsInterop', :path => '../'
910
pod 'FirebaseAuth', :path => '../'
11+
pod 'FirebaseAuthInterop', :path => '../'
1012
pod 'FirebaseDatabase', :path => '../'
1113
pod 'FirebaseDynamicLinks', :path => '../'
1214
pod 'FirebaseFirestore', :path => '../'

SymbolCollisionTest/Podfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,12 @@ target 'SymbolCollisionTest' do
1010
# Firebase Pods
1111
pod 'Firebase', :path => '../'
1212
pod 'FirebaseAnalytics'
13+
pod 'FirebaseAnalyticsInterop', :path => '../'
1314
pod 'FirebaseAuth', :path => '../'
15+
pod 'FirebaseAuthInterop', :path => '../'
1416
pod 'FirebaseCore', :path => '../'
17+
pod 'FirebaseCoreDiagnostics', :path => '../'
18+
pod 'FirebaseCoreDiagnosticsInterop', :path => '../'
1519
pod 'FirebaseCrashlytics', :path => '../'
1620
pod 'FirebaseDatabase', :path => '../'
1721
pod 'FirebaseDynamicLinks', :path => '../'

ZipBuilder/Sources/ZipBuilder/CocoaPodUtils.swift

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -341,14 +341,17 @@ enum CocoaPodUtils {
341341
}
342342

343343
// If we're using local pods, explicitly add FirebaseInstanceID, FirebaseInstallations,
344-
// and any Google* podspecs if they exist and there are no
344+
// the Interop pods, and any Google* podspecs if they exist and there are no
345345
// explicit versions in the Podfile. Note there are versions for local podspecs if we're doing
346346
// the secondary install for module map building.
347347
if !versionsSpecified, let localURL = LaunchArgs.shared.localPodspecPath {
348348
let podspecs = try! FileManager.default.contentsOfDirectory(atPath: localURL.path)
349349
for podspec in podspecs {
350350
if (podspec == "FirebaseInstanceID.podspec" ||
351-
podspec == "FirebaseInstallations.podspec") ||
351+
podspec == "FirebaseInstallations.podspec" ||
352+
podspec == "FirebaseAnalyticsInterop.podspec" ||
353+
podspec == "FirebaseAuthInterop.podspec" ||
354+
podspec == "FirebaseCoreDiagnostics.podspec") ||
352355
podspec.starts(with: "Google"), podspec.hasSuffix(".podspec") {
353356
let podName = podspec.replacingOccurrences(of: ".podspec", with: "")
354357
podfile += " pod '\(podName)', :path => '\(localURL.path)/\(podspec)'\n"

scripts/localize_podfile.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ let podfile = CommandLine.arguments[1]
2626
// versions when they're dependencies of other requested local pods.
2727
let implicitPods = ["FirebaseCore", "FirebaseInstanceID", "FirebaseInstallations", "Firebase",
2828
"GoogleDataTransport", "GoogleDataTransportCCTSupport", "GoogleUtilities",
29-
"FirebaseCoreDiagnostics", "FirebaseRemoteConfig", "FirebaseAuthInterop"]
29+
"FirebaseAnalyticsInterop", "FirebaseAuthInterop", "FirebaseCoreDiagnostics",
30+
"FirebaseCoreDiagnosticsInterop", "FirebaseRemoteConfig", "FirebaseAuthInterop"]
3031
var didImplicits = false
3132

3233
var fileContents = ""

0 commit comments

Comments
 (0)