Skip to content

Commit 55463b1

Browse files
authored
Update to latest version of FirebaseAnalyticsInterop (#3463)
1 parent ac34398 commit 55463b1

File tree

5 files changed

+50
-34
lines changed

5 files changed

+50
-34
lines changed

Example/DynamicLinks/Tests/FIRDLScionLoggingTest.m

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,19 +57,10 @@ - (void)clearConditionalUserProperty:(nonnull NSString *)userPropertyName
5757
clearEventParameters:(nonnull NSDictionary *)clearEventParameters {
5858
}
5959

60-
- (nonnull NSArray<FIRAConditionalUserProperty *> *)
61-
conditionalUserProperties:(nonnull NSString *)origin
62-
propertyNamePrefix:(nonnull NSString *)propertyNamePrefix {
63-
return @[];
64-
}
65-
6660
- (NSInteger)maxUserProperties:(nonnull NSString *)origin {
6761
return -1;
6862
}
6963

70-
- (void)setConditionalUserProperty:(nonnull FIRAConditionalUserProperty *)conditionalUserProperty {
71-
}
72-
7364
- (void)setUserPropertyWithOrigin:(nonnull NSString *)origin
7465
name:(nonnull NSString *)name
7566
value:(nonnull id)value {
@@ -88,6 +79,22 @@ - (void)registerAnalyticsListener:(nonnull id<FIRAnalyticsInteropListener>)liste
8879
- (void)unregisterAnalyticsListenerWithOrigin:(nonnull NSString *)origin {
8980
}
9081

82+
- (void)clearConditionalUserProperty:(nonnull NSString *)userPropertyName
83+
forOrigin:(nonnull NSString *)origin
84+
clearEventName:(nonnull NSString *)clearEventName
85+
clearEventParameters:
86+
(nonnull NSDictionary<NSString *, NSString *> *)clearEventParameters {
87+
}
88+
89+
- (nonnull NSArray<NSDictionary<NSString *, NSString *> *> *)
90+
conditionalUserProperties:(nonnull NSString *)origin
91+
propertyNamePrefix:(nonnull NSString *)propertyNamePrefix {
92+
return nil;
93+
}
94+
95+
- (void)setConditionalUserProperty:(nonnull NSDictionary<NSString *, id> *)conditionalUserProperty {
96+
}
97+
9198
@end
9299

93100
@interface FIRDLScionLoggingTest : XCTestCase

Example/Messaging/Tests/FIRMessagingAnalyticsTest.m

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -86,19 +86,10 @@ - (void)clearConditionalUserProperty:(nonnull NSString *)userPropertyName
8686
clearEventParameters:(nonnull NSDictionary *)clearEventParameters {
8787
}
8888

89-
- (nonnull NSArray<FIRAConditionalUserProperty *> *)
90-
conditionalUserProperties:(nonnull NSString *)origin
91-
propertyNamePrefix:(nonnull NSString *)propertyNamePrefix {
92-
return @[];
93-
}
94-
9589
- (NSInteger)maxUserProperties:(nonnull NSString *)origin {
9690
return -1;
9791
}
9892

99-
- (void)setConditionalUserProperty:(nonnull FIRAConditionalUserProperty *)conditionalUserProperty {
100-
}
101-
10293
- (void)checkLastNotificationForOrigin:(nonnull NSString *)origin
10394
queue:(nonnull dispatch_queue_t)queue
10495
callback:(nonnull void (^)(NSString *_Nullable))
@@ -112,6 +103,16 @@ - (void)registerAnalyticsListener:(nonnull id<FIRAnalyticsInteropListener>)liste
112103
- (void)unregisterAnalyticsListenerWithOrigin:(nonnull NSString *)origin {
113104
}
114105

106+
- (void)clearConditionalUserProperty:(nonnull NSString *)userPropertyName forOrigin:(nonnull NSString *)origin clearEventName:(nonnull NSString *)clearEventName clearEventParameters:(nonnull NSDictionary<NSString *,NSString *> *)clearEventParameters {
107+
}
108+
109+
- (nonnull NSArray<NSDictionary<NSString *,NSString *> *> *)conditionalUserProperties:(nonnull NSString *)origin propertyNamePrefix:(nonnull NSString *)propertyNamePrefix {
110+
return nil;
111+
}
112+
113+
114+
- (void)setConditionalUserProperty:(nonnull NSDictionary<NSString *,id> *)conditionalUserProperty {
115+
}
115116

116117
@end
117118

FirebaseAnalyticsInterop.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = 'FirebaseAnalyticsInterop'
3-
s.version = '1.2.0'
3+
s.version = '1.3.0'
44
s.summary = 'Interfaces that allow other Firebase SDKs to use Analytics functionality.'
55

66
s.description = <<-DESC

InAppMessaging/Example/Tests/FIRIAMAnalyticsEventLoggerImplTests.m

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -103,25 +103,33 @@ - (void)clearConditionalUserProperty:(nonnull NSString *)userPropertyName
103103
clearEventParameters:(nonnull NSDictionary *)clearEventParameters {
104104
}
105105

106-
- (nonnull NSArray<FIRAConditionalUserProperty *> *)
107-
conditionalUserProperties:(nonnull NSString *)origin
108-
propertyNamePrefix:(nonnull NSString *)propertyNamePrefix {
109-
return @[];
110-
}
111-
112106
- (NSInteger)maxUserProperties:(nonnull NSString *)origin {
113107
return -1;
114108
}
115109

116-
- (void)setConditionalUserProperty:(nonnull FIRAConditionalUserProperty *)conditionalUserProperty {
117-
}
118-
119110
- (void)registerAnalyticsListener:(nonnull id<FIRAnalyticsInteropListener>)listener
120111
withOrigin:(nonnull NSString *)origin {
121112
}
122113

123114
- (void)unregisterAnalyticsListenerWithOrigin:(nonnull NSString *)origin {
124115
}
116+
117+
- (void)clearConditionalUserProperty:(nonnull NSString *)userPropertyName
118+
forOrigin:(nonnull NSString *)origin
119+
clearEventName:(nonnull NSString *)clearEventName
120+
clearEventParameters:
121+
(nonnull NSDictionary<NSString *, NSString *> *)clearEventParameters {
122+
}
123+
124+
- (nonnull NSArray<NSDictionary<NSString *, NSString *> *> *)
125+
conditionalUserProperties:(nonnull NSString *)origin
126+
propertyNamePrefix:(nonnull NSString *)propertyNamePrefix {
127+
return nil;
128+
}
129+
130+
- (void)setConditionalUserProperty:(nonnull NSDictionary<NSString *, id> *)conditionalUserProperty {
131+
}
132+
125133
@end
126134

127135
@implementation FIRIAMAnalyticsEventLoggerImplTests

Interop/Analytics/Public/FIRAnalyticsInterop.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
#import <Foundation/Foundation.h>
1818

19-
@class FIRAConditionalUserProperty;
2019
@protocol FIRAnalyticsInteropListener;
2120

2221
NS_ASSUME_NONNULL_BEGIN
@@ -25,17 +24,18 @@ NS_ASSUME_NONNULL_BEGIN
2524
@protocol FIRAnalyticsInterop
2625

2726
/// Sets user property when trigger event is logged. This API is only available in the SDK.
28-
- (void)setConditionalUserProperty:(FIRAConditionalUserProperty *)conditionalUserProperty;
27+
- (void)setConditionalUserProperty:(NSDictionary<NSString *, id> *)conditionalUserProperty;
2928

3029
/// Clears user property if set.
3130
- (void)clearConditionalUserProperty:(NSString *)userPropertyName
31+
forOrigin:(NSString *)origin
3232
clearEventName:(NSString *)clearEventName
33-
clearEventParameters:(NSDictionary *)clearEventParameters;
33+
clearEventParameters:(NSDictionary<NSString *, NSString *> *)clearEventParameters;
3434

3535
/// Returns currently set user properties.
36-
- (NSArray<FIRAConditionalUserProperty *> *)conditionalUserProperties:(NSString *)origin
37-
propertyNamePrefix:
38-
(NSString *)propertyNamePrefix;
36+
- (NSArray<NSDictionary<NSString *, NSString *> *> *)conditionalUserProperties:(NSString *)origin
37+
propertyNamePrefix:
38+
(NSString *)propertyNamePrefix;
3939

4040
/// Returns the maximum number of user properties.
4141
- (NSInteger)maxUserProperties:(NSString *)origin;

0 commit comments

Comments
 (0)