GoogleUtilities to testspec and pod gen (#2908)

Author: paulb777

.travis.yml

@@ -102,14 +102,23 @@ jobs:
       script:
         - travis_retry ./scripts/if_changed.sh ./scripts/build.sh $PROJECT $PLATFORM $METHOD
 
+    - stage: test
+      env:
+        - PROJECT=GoogleUtilities PLATFORM=iOS METHOD=pod-lib-lint
+      before_install:
+        - ./scripts/if_changed.sh ./scripts/install_prereqs.sh
+      script:
+        - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb GoogleUtilities.podspec
+        - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb GoogleUtilities.podspec --use-libraries
+        - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb GoogleUtilities.podspec --use-modular-headers
+
     # pod lib lint to check build and warnings for dynamic framework build (use_frameworks!)
     - stage: test
       env:
         - PROJECT=Firebase PLATFORM=iOS METHOD=pod-lib-lint
       before_install:
         - ./scripts/if_changed.sh ./scripts/install_prereqs.sh
       script:
-        - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb GoogleUtilities.podspec
         - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseAnalyticsInterop.podspec
         - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseAuth.podspec
         - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseAuthInterop.podspec
@@ -136,7 +145,6 @@ jobs:
       before_install:
         - ./scripts/install_prereqs.sh
       script:
-        - travis_retry ./scripts/pod_lib_lint.rb GoogleUtilities.podspec --use-libraries
         - travis_retry ./scripts/pod_lib_lint.rb FirebaseAnalyticsInterop.podspec --use-libraries
         - travis_retry ./scripts/pod_lib_lint.rb FirebaseAuth.podspec --use-libraries
         - travis_retry ./scripts/pod_lib_lint.rb FirebaseAuthInterop.podspec --use-libraries

GoogleUtilities.podspec

@@ -99,4 +99,12 @@ other Google CocoaPods. They're not intended for direct public usage.
     ud.private_header_files = 'GoogleUtilities/UserDefaults/Private/*.h'
     ud.dependency 'GoogleUtilities/Logger'
   end
+
+  s.test_spec 'unit' do |unit_tests|
+    # All tests require arc except Tests/Network/third_party/GTMHTTPServer.m
+    unit_tests.source_files = 'GoogleUtilities/Example/Tests/**/*.[mh]'
+    unit_tests.requires_arc = 'GoogleUtilities/Example/Tests/*/*.[mh]'
+    unit_tests.requires_app_host = true
+    unit_tests.dependency 'OCMock'
+  end
 end

GoogleUtilities/Example/Tests/Network/third_party/GTMHTTPServer.m

@@ -127,13 +127,6 @@ - (void)dealloc {
   [super dealloc];
 }
 
-#if !TARGET_OS_IPHONE
-- (void)finalize {
-  [self stop];
-  [super finalize];
-}
-#endif
-
 - (id)delegate {
   return delegate_;
 }

GoogleUtilities/Example/Tests/Swizzler/GULAppDelegateSwizzlerTest.m

@@ -91,7 +91,9 @@ @implementation GULTestAppDelegate
 /** YES if GULTestAppDelegate responds to application:openURL:sourceApplication:annotation:, NO
  *  otherwise.
  */
+#if TARGET_OS_IOS || TARGET_OS_TV
 static BOOL gRespondsToOpenURLHandler_iOS8;
+#endif
 
 /** YES if GULTestAppDelegate responds to application:openURL:options:, NO otherwise. */
 static BOOL gRespondsToOpenURLHandler_iOS9;
@@ -109,10 +111,13 @@ @implementation GULTestAppDelegate
 + (void)load {
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
   // Before being proxied, it should be only be able to respond to
   // application:openURL:sourceApplication:annotation:.
+#if TARGET_OS_IOS || TARGET_OS_TV
   gRespondsToOpenURLHandler_iOS8 = [self
       instancesRespondToSelector:@selector(application:openURL:sourceApplication:annotation:)];
+#endif
   gRespondsToOpenURLHandler_iOS9 =
       [self instancesRespondToSelector:@selector(application:openURL:options:)];
   gRespondsToHandleBackgroundSession =

GoogleUtilities/README.md

@@ -15,15 +15,24 @@ Instructions on how to adopt the app delegate swizzler for use by your SDK are a
 
 ## Development
 
-Follow the subsequent instructions to develop, debug, and unit test
-GoogleUtilities:
-
-```
-$ git clone [email protected]:firebase/firebase-ios-sdk.git
-$ cd firebase-ios-sdk/GoogleUtilities/Example
-$ pod update
-$ open GoogleUtilities.xcworkspace
-```
+Follow the subsequent instructions to develop, debug, unit test, and
+integration test FirebaseFunctions:
+
+### Prereqs
+
+- At least CocoaPods 1.7.0
+
+### To Develop
+
+- Run `pod gen GoogleUtilities.podspec`
+- `open gen/GoogleUtilities/GoogleUtilities.xcworkspace`
+
+OR these two commands can be combined with
+
+- `pod gen GoogleUtilities.podspec --auto-open --gen-directory="gen" --clean`
+
+You're now in an Xcode workspace generate for building, debugging and
+testing the GoogleUtilities CocoaPod.
 
 ### Running Unit Tests
 

scripts/if_changed.sh

@@ -78,6 +78,10 @@ else
       check_changes '^(Firebase/Core|Functions|GoogleUtilities|FirebaseFunctions.podspec)'
       ;;
 
+    GoogleUtilities-*)
+      check_changes '^(GoogleUtilities|GoogleUtilities.podspec)'
+      ;;
+
     InAppMessaging-*)
       check_changes '^(Firebase/InAppMessagingDisplay|InAppMessagingDisplay|InAppMessaging|'\
 'Firebase/InAppMessaging)'