GoogleUtilities unit tests on iOS 8 (#3093)

* GULAppDelegateSwizzlerTest iOS 8 fixes

* GULRuntimeClassSnapshot - NSAssert replaced with a condition to fix implementation for iOS 8

Author: maksymmalyhin

GoogleUtilities/Example/Tests/Swizzler/GULAppDelegateSwizzlerTest.m

@@ -642,6 +642,13 @@ - (void)testNotOverriddenMethods {
  *  handles it correctly.
  */
 - (void)testAppDelegateInstance {
+  // The test logic involves using KVC on the UIApplication.delegate propery. This does not really
+  // work well with OCMPartialMock([GULApplication sharedApplication]) and triggers issue
+  // https://github.com/erikdoe/ocmock/issues/346.
+  // Let's stop mocking the shared application for this particular test.
+  [self.mockSharedApplication stopMocking];
+  self.mockSharedApplication = nil;
+
   GULTestAppDelegate *realAppDelegate = [[GULTestAppDelegate alloc] init];
 
   [GULApplication sharedApplication].delegate = realAppDelegate;
@@ -667,72 +674,76 @@ - (void)testAppDelegateInstance {
 #if TARGET_OS_IOS || TARGET_OS_TV
 /** Tests that application:openURL:options: is invoked on the interceptor if it exists. */
 - (void)testApplicationOpenURLOptionsIsInvokedOnInterceptors {
-  id interceptor = OCMProtocolMock(@protocol(GULApplicationDelegate));
-  OCMExpect([interceptor application:OCMOCK_ANY openURL:OCMOCK_ANY options:OCMOCK_ANY])
-      .andReturn(NO);
-
-  id interceptor2 = OCMProtocolMock(@protocol(GULApplicationDelegate));
-  OCMExpect([interceptor2 application:OCMOCK_ANY openURL:OCMOCK_ANY options:OCMOCK_ANY])
-      .andReturn(NO);
-
-  NSURL *testURL = [[NSURL alloc] initWithString:@"https://www.google.com"];
-  NSDictionary *testOpenURLOptions = @{UIApplicationOpenURLOptionUniversalLinksOnly : @"test"};
-
-  GULTestAppDelegate *testAppDelegate = [[GULTestAppDelegate alloc] init];
-  OCMStub([self.mockSharedApplication delegate]).andReturn(testAppDelegate);
-
-  [GULAppDelegateSwizzler proxyOriginalDelegate];
-  [GULAppDelegateSwizzler registerAppDelegateInterceptor:interceptor];
-  [GULAppDelegateSwizzler registerAppDelegateInterceptor:interceptor2];
-
-  [testAppDelegate application:[GULApplication sharedApplication]
-                       openURL:testURL
-                       options:testOpenURLOptions];
-  OCMVerifyAll(interceptor);
-  OCMVerifyAll(interceptor2);
-
-  // Check that original implementation was called with proper parameters
-  XCTAssertEqual(testAppDelegate.application, [GULApplication sharedApplication]);
-  XCTAssertEqual(testAppDelegate.url, testURL);
+  if (@available(iOS 10, *)) {
+    id interceptor = OCMProtocolMock(@protocol(GULApplicationDelegate));
+    OCMExpect([interceptor application:OCMOCK_ANY openURL:OCMOCK_ANY options:OCMOCK_ANY])
+        .andReturn(NO);
+
+    id interceptor2 = OCMProtocolMock(@protocol(GULApplicationDelegate));
+    OCMExpect([interceptor2 application:OCMOCK_ANY openURL:OCMOCK_ANY options:OCMOCK_ANY])
+        .andReturn(NO);
+
+    NSURL *testURL = [[NSURL alloc] initWithString:@"https://www.google.com"];
+    NSDictionary *testOpenURLOptions = @{UIApplicationOpenURLOptionUniversalLinksOnly : @"test"};
+
+    GULTestAppDelegate *testAppDelegate = [[GULTestAppDelegate alloc] init];
+    OCMStub([self.mockSharedApplication delegate]).andReturn(testAppDelegate);
+
+    [GULAppDelegateSwizzler proxyOriginalDelegate];
+    [GULAppDelegateSwizzler registerAppDelegateInterceptor:interceptor];
+    [GULAppDelegateSwizzler registerAppDelegateInterceptor:interceptor2];
+
+    [testAppDelegate application:[GULApplication sharedApplication]
+                         openURL:testURL
+                         options:testOpenURLOptions];
+    OCMVerifyAll(interceptor);
+    OCMVerifyAll(interceptor2);
+
+    // Check that original implementation was called with proper parameters
+    XCTAssertEqual(testAppDelegate.application, [GULApplication sharedApplication]);
+    XCTAssertEqual(testAppDelegate.url, testURL);
+  }
 }
 
 /** Tests that the result of application:openURL:options: from all interceptors is ORed. */
 - (void)testResultOfApplicationOpenURLOptionsIsORed {
-  NSURL *testURL = [[NSURL alloc] initWithString:@"https://www.google.com"];
-  NSDictionary *testOpenURLOptions = @{UIApplicationOpenURLOptionUniversalLinksOnly : @"test"};
-
-  GULTestAppDelegate *testAppDelegate = [[GULTestAppDelegate alloc] init];
-  OCMStub([self.mockSharedApplication delegate]).andReturn(testAppDelegate);
-  [GULAppDelegateSwizzler proxyOriginalDelegate];
-
-  BOOL shouldOpen = [testAppDelegate application:[GULApplication sharedApplication]
-                                         openURL:testURL
-                                         options:testOpenURLOptions];
-  // Verify that the original app delegate returns NO.
-  XCTAssertFalse(shouldOpen);
-
-  id interceptor = OCMProtocolMock(@protocol(GULApplicationDelegate));
-  OCMExpect([interceptor application:OCMOCK_ANY openURL:OCMOCK_ANY options:OCMOCK_ANY])
-      .andReturn(NO);
-  [GULAppDelegateSwizzler registerAppDelegateInterceptor:interceptor];
-  shouldOpen = [testAppDelegate application:[GULApplication sharedApplication]
-                                    openURL:testURL
-                                    options:testOpenURLOptions];
-  // Verify that if the only interceptor returns NO, the value is still NO.
-  XCTAssertFalse(shouldOpen);
-
-  id interceptor2 = OCMProtocolMock(@protocol(GULApplicationDelegate));
-  OCMExpect([interceptor2 application:OCMOCK_ANY openURL:OCMOCK_ANY options:OCMOCK_ANY])
-      .andReturn(YES);
-  [GULAppDelegateSwizzler registerAppDelegateInterceptor:interceptor2];
-
-  OCMExpect([interceptor application:OCMOCK_ANY openURL:OCMOCK_ANY options:OCMOCK_ANY])
-      .andReturn(NO);
-  shouldOpen = [testAppDelegate application:[GULApplication sharedApplication]
-                                    openURL:testURL
-                                    options:testOpenURLOptions];
-  // Verify that if one of the two interceptors returns YES, the value is YES.
-  XCTAssertTrue(shouldOpen);
+  if (@available(iOS 10, *)) {
+    NSURL *testURL = [[NSURL alloc] initWithString:@"https://www.google.com"];
+    NSDictionary *testOpenURLOptions = @{UIApplicationOpenURLOptionUniversalLinksOnly : @"test"};
+
+    GULTestAppDelegate *testAppDelegate = [[GULTestAppDelegate alloc] init];
+    OCMStub([self.mockSharedApplication delegate]).andReturn(testAppDelegate);
+    [GULAppDelegateSwizzler proxyOriginalDelegate];
+
+    BOOL shouldOpen = [testAppDelegate application:[GULApplication sharedApplication]
+                                           openURL:testURL
+                                           options:testOpenURLOptions];
+    // Verify that the original app delegate returns NO.
+    XCTAssertFalse(shouldOpen);
+
+    id interceptor = OCMProtocolMock(@protocol(GULApplicationDelegate));
+    OCMExpect([interceptor application:OCMOCK_ANY openURL:OCMOCK_ANY options:OCMOCK_ANY])
+        .andReturn(NO);
+    [GULAppDelegateSwizzler registerAppDelegateInterceptor:interceptor];
+    shouldOpen = [testAppDelegate application:[GULApplication sharedApplication]
+                                      openURL:testURL
+                                      options:testOpenURLOptions];
+    // Verify that if the only interceptor returns NO, the value is still NO.
+    XCTAssertFalse(shouldOpen);
+
+    id interceptor2 = OCMProtocolMock(@protocol(GULApplicationDelegate));
+    OCMExpect([interceptor2 application:OCMOCK_ANY openURL:OCMOCK_ANY options:OCMOCK_ANY])
+        .andReturn(YES);
+    [GULAppDelegateSwizzler registerAppDelegateInterceptor:interceptor2];
+
+    OCMExpect([interceptor application:OCMOCK_ANY openURL:OCMOCK_ANY options:OCMOCK_ANY])
+        .andReturn(NO);
+    shouldOpen = [testAppDelegate application:[GULApplication sharedApplication]
+                                      openURL:testURL
+                                      options:testOpenURLOptions];
+    // Verify that if one of the two interceptors returns YES, the value is YES.
+    XCTAssertTrue(shouldOpen);
+  }
 }
 #endif  // TARGET_OS_IOS || TARGET_OS_TV
 

GoogleUtilities/SwizzlerTestHelpers/GULRuntimeClassSnapshot.m

@@ -132,10 +132,9 @@ - (void)captureSelectorsAndImps {
     IMP imp = method_getImplementation(method);
     NSString *impString =
         [NSString stringWithFormat:@"%p -[%@ %@]", imp, NSStringFromClass(_aClass), methodString];
-    NSAssert(![_imps containsObject:impString],
-             @"This IMP/method combination has already been captured: %@:%@",
-             NSStringFromClass(_aClass), impString);
-    [_imps addObject:impString];
+    if (![_imps containsObject:impString]) {
+      [_imps addObject:impString];
+    }
     _runningHash ^= [impString hash];
   }
   free(instanceMethods);