Skip to content

Commit 5c4893c

Browse files
authored
[FirestoreSwift] Add FirebaseCore dependency to avoid linker issues (#10319) (#10321)
* [FirestoreSwift] Add FirebaseCore dependency * Add note about FirebaseCoreExtension
1 parent 41ea71f commit 5c4893c

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

FirebaseCoreExtension.podspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ Pod::Spec.new do |s|
66
s.description = <<-DESC
77
Not for public use.
88
Common FirebaseCore APIs for use in Firebase product SDKs.
9+
When depending on `FirebaseCoreExtension`, also depend on `FirebaseCore` to
10+
avoid potential linker issues.
911
DESC
1012

1113
s.homepage = 'https://firebase.google.com'

FirebaseFirestoreSwift.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ Google Cloud Firestore is a NoSQL document database built for automatic scaling,
3434
'Firestore/Swift/Source/**/*.swift',
3535
]
3636

37+
s.dependency 'FirebaseCore', '~> 10.0'
3738
s.dependency 'FirebaseCoreExtension', '~> 10.0'
3839
s.dependency 'FirebaseFirestore', '~> 10.0'
3940
s.dependency 'FirebaseSharedSwift', '~> 10.0'

Package.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,8 @@ let package = Package(
242242
// MARK: - Firebase Core Extension
243243

244244
// Extension of FirebaseCore for consuming by Swift product SDKs.
245+
// When depending on `FirebaseCoreExtension`, also depend on `FirebaseCore`
246+
// to avoid potential linker issues.
245247
.target(
246248
name: "FirebaseCoreExtension",
247249
path: "FirebaseCore/Extension",
@@ -702,6 +704,7 @@ let package = Package(
702704
.target(
703705
name: "FirebaseFirestoreSwift",
704706
dependencies: [
707+
"FirebaseCore",
705708
"FirebaseCoreExtension",
706709
"FirebaseFirestore",
707710
"FirebaseSharedSwift",

0 commit comments

Comments
 (0)