Skip to content

Commit 5ccb81f

Browse files
Update PhoneAuthProvider.swift addressing comments
1 parent f36c832 commit 5ccb81f

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

FirebaseAuth/Sources/Swift/AuthProvider/PhoneAuthProvider.swift

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ import Foundation
2222
@objc(FIRPhoneAuthProvider) open class PhoneAuthProvider: NSObject {
2323
/// A string constant identifying the phone identity provider.
2424
@objc public static let id = "phone"
25-
@objc private static let kRecaptchaVersion = "RECAPTCHA_ENTERPRISE"
26-
@objc private static let kClientType = "CLIENT_TYPE_IOS"
27-
@objc private static let kFakeCaptchaResponse = "NO_RECAPTCHA"
25+
private static let recaptchaVersion = "RECAPTCHA_ENTERPRISE"
26+
private static let clientType = "CLIENT_TYPE_IOS"
27+
private static let fakeCaptchaResponse = "NO_RECAPTCHA"
2828

2929
#if os(iOS)
3030
/// Returns an instance of `PhoneAuthProvider` for the default `Auth` object.
@@ -260,7 +260,7 @@ import Foundation
260260
}
261261

262262
/// Starts the flow to verify the client via silent push notification.
263-
/// - Parameter retryOnInvalidAppCredential: Whether of not the flow should be retried if an
263+
/// - Parameter retryOnInvalidAppCredential: Whether or not the flow should be retried if an
264264
/// AuthErrorCodeInvalidAppCredential error is returned from the backend.
265265
/// - Parameter phoneNumber: The phone number to be verified.
266266
/// - Parameter callback: The callback to be invoked on the global work queue when the flow is
@@ -277,8 +277,8 @@ import Foundation
277277
.requestConfiguration)
278278
if auditFallback {
279279
request.injectRecaptchaFields(
280-
recaptchaResponse: PhoneAuthProvider.kFakeCaptchaResponse,
281-
recaptchaVersion: PhoneAuthProvider.kRecaptchaVersion
280+
recaptchaResponse: PhoneAuthProvider.fakeCaptchaResponse,
281+
recaptchaVersion: PhoneAuthProvider.recaptchaVersion
282282
)
283283
}
284284
do {
@@ -402,9 +402,9 @@ import Foundation
402402
codeIdentity: codeIdentity)
403403
if auditFallback {
404404
startMFARequestInfo.injectRecaptchaFields(
405-
recaptchaResponse: PhoneAuthProvider.kFakeCaptchaResponse,
406-
recaptchaVersion: PhoneAuthProvider.kRecaptchaVersion,
407-
clientType: PhoneAuthProvider.kClientType
405+
recaptchaResponse: PhoneAuthProvider.fakeCaptchaResponse,
406+
recaptchaVersion: PhoneAuthProvider.recaptchaVersion,
407+
clientType: PhoneAuthProvider.clientType
408408
)
409409
}
410410
do {

0 commit comments

Comments
 (0)