Skip to content

Commit 5fcde3c

Browse files
authored
Flip the default to diffing against master (#4631)
In implementing the fallback for old PRs in #4614 I changed the default for interactive use of check.sh. This fixes it so that if you just run check.sh with no arguments it evaluates only the diff against master.
1 parent 823a02c commit 5fcde3c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

scripts/check.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ cd "${top_dir}"
8484

8585
ALLOW_DIRTY=false
8686
COMMIT_METHOD="none"
87-
CHECK_DIFF=false
87+
CHECK_DIFF=true
8888
START_REVISION="origin/master"
8989
TEST_ONLY=false
9090
VERBOSE=false
@@ -149,7 +149,6 @@ while [[ $# -gt 0 ]]; do
149149
;;
150150

151151
*)
152-
CHECK_DIFF=true
153152
START_REVISION="$1"
154153
shift
155154
break
@@ -204,7 +203,7 @@ if [[ "${START_REVISION}" == *..* ]]; then
204203
# between the PR and master. In this case just fall back on checking
205204
# everything.
206205
echo "Unable to detect base commit for change detection."
207-
echo "Failling back on just checking everything."
206+
echo "Falling back on just checking everything."
208207
CHECK_DIFF=false
209208
START_REVISION="origin/master"
210209
START_SHA="origin/master"

0 commit comments

Comments
 (0)