Add pods in spec testing (#9190)

* Add pods for spec testing.

Author: granluo

.github/workflows/health-metrics-presubmit.yml

@@ -12,7 +12,7 @@ env:
 
 jobs:
   # Check all the modified SDKs, the flags will be true if changed files match patterns in the file
-  # scripts/health_metrics/code_coverage_file_list.json
+  # scripts/health_metrics/file_patterns.json
   check:
     if: github.repository == 'Firebase/firebase-ios-sdk' && (github.event.action == 'opened' || github.event.action == 'synchronize')
     name: Check changed files

scripts/health_metrics/README.md

@@ -3,17 +3,17 @@ This directory includes code coverage report generation and binary size report g
 
 ## Code Coverage Report Generation
 
-This tool is to help generate coverage reports for pull requests. It's defined by the [test_coverage  workflow](https://github.com/firebase/firebase-ios-sdk/blob/master/scripts/health_metrics/code_coverage_file_list.json).
+This tool is to help generate coverage reports for pull requests. It's defined by the [test_coverage  workflow](https://github.com/firebase/firebase-ios-sdk/blob/master/scripts/health_metrics/file_patterns.json).
 
 Coverage reports of SDK frameworks will be displayed in a pull request if the change is under corresponding SDK file patterns.
 
-[UpdatedFilesCollector](https://github.com/firebase/firebase-ios-sdk/tree/master/scripts/health_metrics/generate_code_coverage_report/Sources/UpdatedFilesCollector) will detect file changes and compare file paths to file patterns in [code_coverage_file_list.json](https://github.com/firebase/firebase-ios-sdk/blob/master/scripts/health_metrics/code_coverage_file_list.json). If updated file paths fit any patterns, corresponding SDK coverage job will be triggered.
+[UpdatedFilesCollector](https://github.com/firebase/firebase-ios-sdk/tree/master/scripts/health_metrics/generate_code_coverage_report/Sources/UpdatedFilesCollector) will detect file changes and compare file paths to file patterns in [file_patterns.json](https://github.com/firebase/firebase-ios-sdk/blob/master/scripts/health_metrics/file_patterns.json). If updated file paths fit any patterns, corresponding SDK coverage job will be triggered.
 
 ### Add a new coverage workflow
 
 To create a code coverage workflow for a new SDK,
-1. Add `newsdk` and its patterns in [code_coverage_file_list.json](https://github.com/firebase/firebase-ios-sdk/blob/master/scripts/health_metrics/code_coverage_file_list.json).
-2. Add a new output flag, e.g. `newsdk_run_job`, in the [coverage workflow](https://github.com/firebase/firebase-ios-sdk/blob/64d50a7f7b3af104a88f9c9203285ae20ea309d4/.github/workflows/test_coverage.yml#L17). `newsdk_run_job` should be aligned with the name of SDK `newsdk` in code_coverage_file_list.json.
+1. Add `newsdk` and its patterns in [file_patterns.json](https://github.com/firebase/firebase-ios-sdk/blob/master/scripts/health_metrics/file_patterns.json).
+2. Add a new output flag, e.g. `newsdk_run_job`, in the [coverage workflow](https://github.com/firebase/firebase-ios-sdk/blob/64d50a7f7b3af104a88f9c9203285ae20ea309d4/.github/workflows/test_coverage.yml#L17). `newsdk_run_job` should be aligned with the name of SDK `newsdk` in file_patterns.json.
 3. Add a newsdk coverage job in the [workflow](https://github.com/firebase/firebase-ios-sdk/blob/master/.github/workflows/test_coverage.yml):
 ```
 pod-lib-lint-newsdk:

scripts/health_metrics/create_binary_size_report.sh

@@ -24,7 +24,7 @@ set -ex
 BINARY_SIZE_SDK=()
 
 # In presubmits, `check` job in the health_metrics.yml workflow will turn on SDK flags if a corresponding
-# file path, in `scripts/health_metrics/code_coverage_file_list.json` is updated.
+# file path, in `scripts/health_metrics/file_patterns.json` is updated.
 # In postsubmits, all SDKs should be measured, so binary size data of all SDKs should be uploaded to a
 # merged commit. Next time a new PR can compare the head of the PR to a commit on the base branch.
 if [[ "${POSTSUBMIT}" == true || "${FirebaseABTesting}" == 'true' ]]; then

scripts/health_metrics/code_coverage_file_list.json renamed to scripts/health_metrics/file_patterns.json

@@ -40,6 +40,24 @@
       "\\.github/workflows/auth\\.yml"
     ]
   },
+  {
+    "sdk": "core",
+    "podspecs": ["FirebaseCore.podspec"],
+    "filePatterns": [
+      "^FirebaseCore.*",
+      "FirebaseCore.podspec",
+      "Interop/CoreDiagnostics/Public/[^/]+\\.h"
+    ]
+  },
+  {
+    "sdk": "core-diagnostics",
+    "podspecs": ["FirebaseCoreDiagnostics.podspec"],
+    "filePatterns": [
+      "Firebase/CoreDiagnostics/.*",
+      "Example/CoreDiagnostics/.*",
+      "Interop/CoreDiagnostics/Public/[^/]+\\.h"
+    ]
+  },
   {
     "sdk": "crashlytics",
     "podspecs": ["FirebaseCrashlytics.podspec"],
@@ -67,6 +85,15 @@
       "Interop/Analytics/Public/[^/]+\\.h"
     ]
   },
+  {
+    "sdk": "firebase",
+    "podspecs": ["Firebase.podspec"],
+    "filePatterns": [
+      ".*.podspec",
+      ".*.podspec.json",
+      "CoreOnly/.*"
+    ]
+  },
   {
     "sdk": "firestore",
     "podspecs": ["FirebaseFirestore.podspec", "FirebaseFirestoreSwift.podspec"],
@@ -92,6 +119,13 @@
       "FirebaseMessaging/Sources/Interop/[^/]+\\.h"
     ]
   },
+  {
+    "sdk": "google-utilities-components",
+    "podspecs": ["GoogleUtilitiesComponents.podspec"],
+    "filePatterns": [
+      "^GoogleUtilitiesComponents.*"
+    ]
+  },
   {
     "sdk": "inappmessaging",
     "podspecs": ["FirebaseInAppMessaging.podspec", "FirebaseInAppMessagingSwift.podspec"],
@@ -118,6 +152,14 @@
       "\\.github/workflows/messaging\\.yml"
     ]
   },
+  {
+    "sdk": "mlmodeldownloader",
+    "podspecs": ["FirebaseMLModelDownloader.podspec"],
+    "filePatterns": [
+      "^FirebaseMLModelDownloader/.*",
+      "FirebaseMLModelDownloader\\.podspec"
+    ]
+  },
   {
     "sdk": "performance",
     "podspecs": ["FirebasePerformance.podspec"],
@@ -137,6 +179,20 @@
       "scripts/generate_access_token\\.sh"
     ]
   },
+  {
+    "sdk": "segmentation",
+    "podspecs": ["FirebaseSegmentation.podspec"],
+    "filePatterns": [
+      "^FirebaseSegmentation.*"
+    ]
+  },
+  {
+    "sdk": "shared-swift",
+    "podspecs": ["FirebaseSharedSwift.podspec"],
+    "filePatterns": [
+      "^FirebaseSharedSwift.*"
+    ]
+  },
   {
     "sdk": "storage",
     "podspecs": ["FirebaseStorage.podspec", "FirebaseStorageSwift.podspec"],

scripts/health_metrics/get_updated_files.sh

@@ -13,7 +13,7 @@
 # limitations under the License.
 
 set -ex
-# Updated files in paths in code_coverage_file_list.json will trigger code coverage workflows.
+# Updated files in paths in file_patterns.json will trigger code coverage workflows.
 # Updates in a pull request will generate a code coverage report in a PR.
 
 while getopts p: flag
@@ -37,8 +37,8 @@ cd scripts/health_metrics/generate_code_coverage_report
 git diff --name-only remotes/origin/${GITHUB_BASE_REF} ${GITHUB_SHA} > updated_files.txt
 
 if [ -z $spec_output_file] ; then
-  swift run UpdatedFilesCollector --changed-file-paths updated_files.txt --code-coverage-file-patterns ../code_coverage_file_list.json
+  swift run UpdatedFilesCollector --changed-file-paths updated_files.txt --code-coverage-file-patterns ../file_patterns.json
 else
-  swift run UpdatedFilesCollector --changed-file-paths updated_files.txt --code-coverage-file-patterns ../code_coverage_file_list.json --output-sdk-file-url "${spec_output_file}"
+  swift run UpdatedFilesCollector --changed-file-paths updated_files.txt --code-coverage-file-patterns ../file_patterns.json --output-sdk-file-url "${spec_output_file}"
   mv "${spec_output_file}" "${dir}"
 fi