Fix connectivity monitor redispatching. (#3663)

wilhuff · web-flow · commit 6d875b489273 · 2019-08-23T08:34:46.000-07:00
In #3467, we changed the connectivity monitor to take callbacks from SCNetworkReachability on the main thread but didn't make the corresponding change to enqueue the notification back onto Firestore's worker.
diff --git a/Firestore/core/src/firebase/firestore/remote/connectivity_monitor_apple.mm b/Firestore/core/src/firebase/firestore/remote/connectivity_monitor_apple.mm
@@ -124,7 +124,7 @@ explicit ConnectivityMonitorApple(
   }
 
   void OnReachabilityChanged(SCNetworkReachabilityFlags flags) {
-    queue()->ExecuteBlocking(
+    queue()->Enqueue(
         [this, flags] { MaybeInvokeCallbacks(ToNetworkStatus(flags)); });
   }
 

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ explicit ConnectivityMonitorApple(`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`void OnReachabilityChanged(SCNetworkReachabilityFlags flags) {`
`127`		`- queue()->ExecuteBlocking(`
	`127`	`+ queue()->Enqueue(`
`128`	`128`	`[this, flags] { MaybeInvokeCallbacks(ToNetworkStatus(flags)); });`
`129`	`129`	`}`
`130`	`130`