Review

Author: ncooke3

FirebaseRemoteConfig/SwiftNew/ConfigExperiment.swift

@@ -18,14 +18,8 @@ import Foundation
 // TODO(ncooke3): Once everything is ported, the `@objc` and `public` access
 // can be removed.
 
-@objc(RCNConfigExperimentFake) public class ConfigExperimentFake: ConfigExperiment {
-  override public func updateExperiments(handler: (((any Error)?) -> Void)? = nil) {
-    handler?(nil)
-  }
-}
-
 /// Handles experiment information update and persistence.
-@objc(RCNConfigExperiment) public class ConfigExperiment: NSObject {
+@objc(RCNConfigExperiment) open class ConfigExperiment: NSObject {
   private static let experimentMetadataKeyLastStartTime = "last_experiment_start_time"
   private static let serviceOrigin = "frc"
 
@@ -128,7 +122,7 @@ import Foundation
   }
 
   /// Update experiments to Firebase Analytics when `activateWithCompletion:` happens.
-  @objc public func updateExperiments(handler: (((any Error)?) -> Void)? = nil) {
+  @objc open func updateExperiments(handler: (((any Error)?) -> Void)? = nil) {
     let lifecycleEvent = LifecycleEvents()
 
     // Get the last experiment start time prior to the latest payload.

FirebaseRemoteConfig/Tests/SwiftUnit/ConfigExperimentFake.swift

@@ -0,0 +1,21 @@
+// Copyright 2024 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+import FirebaseRemoteConfig
+
+@objc(RCNConfigExperimentFake) public class ConfigExperimentFake: ConfigExperiment {
+  override public func updateExperiments(handler: (((any Error)?) -> Void)? = nil) {
+    handler?(nil)
+  }
+}

FirebaseRemoteConfig/Tests/Unit/RCNRemoteConfigTest.m

@@ -18,6 +18,9 @@
 #import <OCMock/OCMock.h>
 #import <XCTest/XCTest.h>
 
+// Import Swift testing fakes.
+#import "FirebaseRemoteConfig_Unit_unit-Swift.h"
+
 @import FirebaseRemoteConfig;
 @import FirebaseCore;
 @import FirebaseABTesting;