Skip to content

Commit 6ecb4ce

Browse files
authored
Review Firestore Integration Tests (#13379)
1 parent cc9a2da commit 6ecb4ce

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

Firestore/Example/Tests/Integration/API/FIRDatabaseTests.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1195,7 +1195,7 @@ - (void)testDocumentID {
11951195
}
11961196

11971197
- (void)testCanQueueWritesWhileOffline {
1198-
XCTestExpectation *writeEpectation = [self expectationWithDescription:@"successfull write"];
1198+
XCTestExpectation *writeEpectation = [self expectationWithDescription:@"successful write"];
11991199
XCTestExpectation *networkExpectation = [self expectationWithDescription:@"enable network"];
12001200

12011201
FIRDocumentReference *doc = [self documentRef];
@@ -1219,7 +1219,7 @@ - (void)testCanQueueWritesWhileOffline {
12191219

12201220
[self awaitExpectations];
12211221

1222-
XCTestExpectation *getExpectation = [self expectationWithDescription:@"successfull get"];
1222+
XCTestExpectation *getExpectation = [self expectationWithDescription:@"successful get"];
12231223
[doc getDocumentWithCompletion:^(FIRDocumentSnapshot *snapshot, NSError *error) {
12241224
XCTAssertNil(error);
12251225
XCTAssertEqualObjects(snapshot.data, data);

Firestore/Example/Tests/Integration/API/FIRFirestoreSourceTests.mm

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ - (void)testGetDocumentWhileOfflineServerOnly {
323323
// go offline for the rest of this test
324324
[self disableNetwork];
325325

326-
// attempt to get doc and ensure it cannot be retreived
326+
// attempt to get doc and ensure it cannot be retrieved
327327
XCTestExpectation *failedGetDocCompletion = [self expectationWithDescription:@"failedGetDoc"];
328328
[doc getDocumentWithSource:FIRFirestoreSourceServer
329329
completion:^(FIRDocumentSnapshot *, NSError *error) {
@@ -349,7 +349,7 @@ - (void)testGetCollectionWhileOfflineServerOnly {
349349
// go offline for the rest of this test
350350
[self disableNetwork];
351351

352-
// attempt to get docs and ensure they cannot be retreived
352+
// attempt to get docs and ensure they cannot be retrieved
353353
XCTestExpectation *failedGetDocsCompletion = [self expectationWithDescription:@"failedGetDocs"];
354354
[col getDocumentsWithSource:FIRFirestoreSourceServer
355355
completion:^(FIRQuerySnapshot *, NSError *error) {
@@ -403,7 +403,7 @@ - (void)testGetDocumentWhileOfflineWithDifferentSource {
403403
XCTAssertTrue(result.metadata.hasPendingWrites);
404404
XCTAssertEqualObjects(result.data, newData);
405405

406-
// attempt to get doc (from the server) and ensure it cannot be retreived
406+
// attempt to get doc (from the server) and ensure it cannot be retrieved
407407
XCTestExpectation *failedGetDocCompletion = [self expectationWithDescription:@"failedGetDoc"];
408408
[doc getDocumentWithSource:FIRFirestoreSourceServer
409409
completion:^(FIRDocumentSnapshot *, NSError *error) {
@@ -477,7 +477,7 @@ - (void)testGetCollectionWhileOfflineWithDifferentSource {
477477
@[ @(FIRDocumentChangeTypeAdded), @"doc4", @{@"key4" : @"value4"} ]
478478
]));
479479

480-
// attempt to get docs (from the server) and ensure they cannot be retreived
480+
// attempt to get docs (from the server) and ensure they cannot be retrieved
481481
XCTestExpectation *failedGetDocsCompletion = [self expectationWithDescription:@"failedGetDocs"];
482482
[col getDocumentsWithSource:FIRFirestoreSourceServer
483483
completion:^(FIRQuerySnapshot *, NSError *error) {
@@ -688,7 +688,7 @@ - (void)testGetNonExistingCollectionWhileOfflineServerOnly {
688688
// go offline for the rest of this test
689689
[self disableNetwork];
690690

691-
// attempt to get collection and ensure that it cannot be retreived
691+
// attempt to get collection and ensure that it cannot be retrieved
692692
XCTestExpectation *failedGetDocsCompletion = [self expectationWithDescription:@"failedGetDocs"];
693693
[col getDocumentsWithSource:FIRFirestoreSourceServer
694694
completion:^(FIRQuerySnapshot *, NSError *error) {

Firestore/Example/Tests/Integration/API/FIRIndexingTests.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ - (void)testBadIndexDoesNotCrashClient {
110110
* sitting inside SDK. So this test only checks the API of auto index creation.
111111
*/
112112
- (void)testAutoIndexCreationSetSuccessfully {
113-
// Use persistent disk cache (explict)
113+
// Use persistent disk cache (explicit)
114114
FIRFirestoreSettings *settings = [self.db settings];
115115
[settings setCacheSettings:[[FIRPersistentCacheSettings alloc] init]];
116116
[self.db setSettings:settings];

0 commit comments

Comments
 (0)