Skip to content

Commit 6f249ca

Browse files
authored
Fix Remote Config travis flakes (#3738)
1 parent b594723 commit 6f249ca

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

FirebaseRemoteConfig/Sources/RCNConfigDBManager.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ - (void)removeDatabaseOnDatabaseQueueAtPath:(NSString *)path {
286286
if (!strongSelf) {
287287
return;
288288
}
289-
RCN_MUST_NOT_BE_MAIN_THREAD();
290289
if (sqlite3_close(strongSelf->_database) != SQLITE_OK) {
291290
[self logDatabaseError];
292291
}

FirebaseRemoteConfig/Tests/Unit/RCNRemoteConfigTest.m

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,7 @@ - (void)setUp {
224224
}
225225

226226
- (void)tearDown {
227-
// Causes crash if main thread exits before the RCNConfigDB queue cleans up
228-
// [_DBManager removeDatabaseOnDatabaseQueueAtPath:_DBPath];
227+
[_DBManager removeDatabaseOnDatabaseQueueAtPath:_DBPath];
229228
[[NSUserDefaults standardUserDefaults] removePersistentDomainForName:_userDefaultsSuiteName];
230229
[super tearDown];
231230
}

0 commit comments

Comments
 (0)