Skip to content

Commit 75a8356

Browse files
authored
Upgrade GoogleTest to 1.8.1 (#3898)
This gives access to testing::ScopedTrace, which was previously internal.
1 parent 971445c commit 75a8356

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

Firestore/Example/GoogleTest.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
Pod::Spec.new do |s|
1919
s.name = 'GoogleTest'
20-
s.version = '1.8.0'
20+
s.version = '1.8.1'
2121
s.summary = 'Google Test'
2222

2323
s.description = <<-DESC

cmake/external/googletest.cmake

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,15 @@
1414

1515
include(ExternalProject)
1616

17-
# Googletest 1.8.0 fails to build on VS 2017:
18-
# https://github.com/google/googletest/issues/1111.
19-
#
20-
# No release has been made since, so just pick a commit since then.
21-
set(commit ba96d0b1161f540656efdaed035b3c062b60e006) # master@{2018-07-10}
17+
set(version 1.8.1)
2218

2319
ExternalProject_Add(
2420
googletest
2521

2622
DOWNLOAD_DIR ${FIREBASE_DOWNLOAD_DIR}
27-
DOWNLOAD_NAME googletest-${commit}.tar.gz
28-
URL https://github.com/google/googletest/archive/${commit}.tar.gz
29-
URL_HASH SHA256=949c556896cf31ed52e53449e17a1276b8b26d3ee5932f5ca49ee929f4b35c51
23+
DOWNLOAD_NAME googletest-${version}.tar.gz
24+
URL https://github.com/google/googletest/archive/release-${version}.tar.gz
25+
URL_HASH SHA256=9bf1fe5182a604b4135edc1a425ae356c9ad15e9b23f9f12a02e80184c3a249c
3026

3127
PREFIX ${PROJECT_BINARY_DIR}
3228

0 commit comments

Comments
 (0)