Skip to content

Commit 76c7aba

Browse files
authored
Update comments on configure call. (#5313)
Currently it mentions that the calls are thread-safe. While technically true, `configure` should only be called from the main thread to ensure all SDKs are configured by the time they are used.
1 parent b5638df commit 76c7aba

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

FirebaseCore/Sources/Public/FIRApp.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,23 +47,23 @@ NS_SWIFT_NAME(FirebaseApp)
4747
/**
4848
* Configures a default Firebase app. Raises an exception if any configuration step fails. The
4949
* default app is named "__FIRAPP_DEFAULT". This method should be called after the app is launched
50-
* and before using Firebase services. This method is thread safe and contains synchronous file I/O
51-
* (reading GoogleService-Info.plist from disk).
50+
* and before using Firebase services. This method should be called from the main thread and
51+
* contains synchronous file I/O (reading GoogleService-Info.plist from disk).
5252
*/
5353
+ (void)configure;
5454

5555
/**
5656
* Configures the default Firebase app with the provided options. The default app is named
57-
* "__FIRAPP_DEFAULT". Raises an exception if any configuration step fails. This method is thread
58-
* safe.
57+
* "__FIRAPP_DEFAULT". Raises an exception if any configuration step fails. This method should be
58+
* called from the main thread.
5959
*
6060
* @param options The Firebase application options used to configure the service.
6161
*/
6262
+ (void)configureWithOptions:(FIROptions *)options NS_SWIFT_NAME(configure(options:));
6363

6464
/**
6565
* Configures a Firebase app with the given name and options. Raises an exception if any
66-
* configuration step fails. This method is thread safe.
66+
* configuration step fails. This method should be called from the main thread.
6767
*
6868
* @param name The application's name given by the developer. The name should should only contain
6969
Letters, Numbers and Underscore.

0 commit comments

Comments
 (0)