make auth build (with warnings and todos)

Author: morganchen12

FirebaseAuth/Interop/Public/FirebaseAuthInterop/FIRAuthInterop.h

@@ -34,8 +34,7 @@ NS_SWIFT_NAME(AuthInterop)
 /// Retrieves the Firebase authentication token, possibly refreshing it if it has expired.
 - (void)getTokenForcingRefresh:(BOOL)forceRefresh
                   withCallback:
-                      (void (^)(NSString *_Nullable_result token, NSError *_Nullable error))callback
-    NS_SWIFT_NAME(getToken(forcingRefresh:completion:));
+                      (void (^NS_SWIFT_UI_ACTOR)(NSString *_Nullable_result token, NSError *_Nullable error))callback NS_SWIFT_NAME(getToken(forcingRefresh:completion:));
 
 /// Get the current Auth user's UID. Returns nil if there is no user signed in.
 - (nullable NSString *)getUserID;

FirebaseAuth/Sources/Swift/ActionCode/ActionCodeInfo.swift

@@ -15,7 +15,7 @@
 import Foundation
 
 /// Manages information regarding action codes.
-@objc(FIRActionCodeInfo) open class ActionCodeInfo: NSObject {
+@objc(FIRActionCodeInfo) final public class ActionCodeInfo: NSObject, Sendable {
   /// The operation being performed.
   @objc public let operation: ActionCodeOperation
 

FirebaseAuth/Sources/Swift/ActionCode/ActionCodeSettings.swift

@@ -15,7 +15,7 @@
 import Foundation
 
 /// Used to set and retrieve settings related to handling action codes.
-@objc(FIRActionCodeSettings) open class ActionCodeSettings: NSObject {
+@objc(FIRActionCodeSettings) open class ActionCodeSettings: NSObject, @unchecked Sendable /* TODO: sendable */ {
   /// This URL represents the state/Continue URL in the form of a universal link.
   ///
   /// This URL can should be constructed as a universal link that would either directly open

FirebaseAuth/Sources/Swift/Auth/Auth.swift

@@ -22,7 +22,7 @@ extension AuthDataResult: NSSecureCoding {}
 ///
 /// It contains references to a `User` instance and an `AdditionalUserInfo` instance.
 @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
-@objc(FIRAuthDataResult) open class AuthDataResult: NSObject {
+@objc(FIRAuthDataResult) open class AuthDataResult: NSObject, @unchecked Sendable /* TODO: sendable */ {
   /// The signed in user.
   @objc public let user: User
 

FirebaseAuth/Sources/Swift/Auth/AuthDataResult.swift

@@ -20,7 +20,7 @@ extension AuthTokenResult: NSSecureCoding {}
 /// A data class containing the ID token JWT string and other properties associated with the
 /// token including the decoded payload claims.
 @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
-@objc(FIRAuthTokenResult) open class AuthTokenResult: NSObject {
+@objc(FIRAuthTokenResult) open class AuthTokenResult: NSObject, @unchecked Sendable /* TODO: sendable */ {
   /// Stores the JWT string of the ID token.
   @objc open var token: String
 

FirebaseAuth/Sources/Swift/Auth/AuthTokenResult.swift

@@ -16,7 +16,7 @@ import Foundation
 
 /// Utility type for constructing federated auth provider credentials.
 @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
-@objc(FIRFederatedAuthProvider) public protocol FederatedAuthProvider: NSObjectProtocol {
+@objc(FIRFederatedAuthProvider) public protocol FederatedAuthProvider: NSObjectProtocol, Sendable {
   #if os(iOS)
 
     /// Used to obtain an auth credential via a mobile web flow.

FirebaseAuth/Sources/Swift/AuthProvider/FederatedAuthProvider.swift

@@ -17,7 +17,7 @@ import Foundation
 
 /// Utility class for constructing OAuth Sign In credentials.
 @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
-@objc(FIROAuthProvider) open class OAuthProvider: NSObject, FederatedAuthProvider {
+@objc(FIROAuthProvider) open class OAuthProvider: NSObject, FederatedAuthProvider, @unchecked Sendable /* TODO: sendable */ {
   @objc public static let id = "OAuth"
 
   /// Array used to configure the OAuth scopes.
@@ -268,7 +268,7 @@ import Foundation
     /// - Parameter completion: Optionally; a block which is invoked asynchronously on the main
     /// thread when the mobile web flow is completed.
     open func getCredentialWith(_ uiDelegate: AuthUIDelegate?,
-                                completion: ((AuthCredential?, Error?) -> Void)? = nil) {
+                                completion: (@MainActor (AuthCredential?, Error?) -> Void)? = nil) {
       guard let urlTypes = auth.mainBundleUrlTypes,
             AuthWebUtils.isCallbackSchemeRegistered(forCustomURLScheme: callbackScheme,
                                                     urlTypes: urlTypes) else {
@@ -281,11 +281,9 @@ import Foundation
         let eventID = AuthWebUtils.randomString(withLength: 10)
         let sessionID = AuthWebUtils.randomString(withLength: 10)
 
-        let callbackOnMainThread: ((AuthCredential?, Error?) -> Void) = { credential, error in
+        let callbackOnMainThread: (@MainActor (AuthCredential?, Error?) -> Void) = { credential, error in
           if let completion {
-            DispatchQueue.main.async {
-              completion(credential, error)
-            }
+            completion(credential, error)
           }
         }
         Task {
@@ -296,13 +294,13 @@ import Foundation
                 "FirebaseAuth Internal Error: Both error and headfulLiteURL return are nil"
               )
             }
-            let callbackMatcher: (URL?) -> Bool = { callbackURL in
+            let callbackMatcher: @Sendable (URL?) -> Bool = { callbackURL in
               AuthWebUtils.isExpectedCallbackURL(callbackURL,
                                                  eventID: eventID,
                                                  authType: "signInWithRedirect",
                                                  callbackScheme: self.callbackScheme)
             }
-            self.auth.authURLPresenter.present(headfulLiteURL,
+            await self.auth.authURLPresenter.present(headfulLiteURL,
                                                uiDelegate: uiDelegate,
                                                callbackMatcher: callbackMatcher) { callbackURL, error in
               if let error {
@@ -328,7 +326,7 @@ import Foundation
               callbackOnMainThread(credential, nil)
             }
           } catch {
-            callbackOnMainThread(nil, error)
+            await callbackOnMainThread(nil, error)
           }
         }
       }

FirebaseAuth/Sources/Swift/AuthProvider/OAuthProvider.swift

@@ -19,7 +19,7 @@ import Foundation
 ///
 /// This class is available on iOS only.
 @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
-@objc(FIRPhoneAuthProvider) open class PhoneAuthProvider: NSObject {
+@objc(FIRPhoneAuthProvider) open class PhoneAuthProvider: NSObject, @unchecked Sendable /* TODO: sendable */ {
   /// A string constant identifying the phone identity provider.
   @objc public static let id = "phone"
   private static let recaptchaVersion = "RECAPTCHA_ENTERPRISE"
@@ -56,7 +56,7 @@ import Foundation
     @objc(verifyPhoneNumber:UIDelegate:completion:)
     open func verifyPhoneNumber(_ phoneNumber: String,
                                 uiDelegate: AuthUIDelegate? = nil,
-                                completion: ((_: String?, _: Error?) -> Void)?) {
+                                completion: (@Sendable (_: String?, _: Error?) -> Void)?) {
       verifyPhoneNumber(phoneNumber,
                         uiDelegate: uiDelegate,
                         multiFactorSession: nil,
@@ -75,7 +75,7 @@ import Foundation
     open func verifyPhoneNumber(_ phoneNumber: String,
                                 uiDelegate: AuthUIDelegate? = nil,
                                 multiFactorSession: MultiFactorSession? = nil,
-                                completion: ((_: String?, _: Error?) -> Void)?) {
+                                completion: (@Sendable (String?, Error?) -> Void)?) {
       Task {
         do {
           let verificationID = try await verifyPhoneNumber(
@@ -135,7 +135,7 @@ import Foundation
     open func verifyPhoneNumber(with multiFactorInfo: PhoneMultiFactorInfo,
                                 uiDelegate: AuthUIDelegate? = nil,
                                 multiFactorSession: MultiFactorSession?,
-                                completion: ((_: String?, _: Error?) -> Void)?) {
+                                completion: (@Sendable (String?, Error?) -> Void)?) {
       Task {
         do {
           let verificationID = try await verifyPhoneNumber(
@@ -531,7 +531,7 @@ import Foundation
           "Internal error: reCAPTCHAURL returned neither a value nor an error. Report issue"
         )
       }
-      let callbackMatcher: (URL?) -> Bool = { callbackURL in
+      let callbackMatcher: @Sendable (URL?) -> Bool = { callbackURL in
         AuthWebUtils.isExpectedCallbackURL(
           callbackURL,
           eventID: eventID,
@@ -540,17 +540,19 @@ import Foundation
         )
       }
 
-      return try await withUnsafeThrowingContinuation { continuation in
-        self.auth.authURLPresenter.present(url,
-                                           uiDelegate: uiDelegate,
-                                           callbackMatcher: callbackMatcher) { callbackURL, error in
-          if let error {
-            continuation.resume(throwing: error)
-          } else {
-            do {
-              try continuation.resume(returning: self.reCAPTCHAToken(forURL: callbackURL))
-            } catch {
+      return try await withCheckedThrowingContinuation { continuation in
+        DispatchQueue.main.async {
+          self.auth.authURLPresenter.present(url,
+                                             uiDelegate: uiDelegate,
+                                             callbackMatcher: callbackMatcher) { callbackURL, error in
+            if let error {
               continuation.resume(throwing: error)
+            } else {
+              do {
+                try continuation.resume(returning: self.reCAPTCHAToken(forURL: callbackURL))
+              } catch {
+                continuation.resume(throwing: error)
+              }
             }
           }
         }

FirebaseAuth/Sources/Swift/AuthProvider/PhoneAuthProvider.swift

@@ -23,7 +23,7 @@ import Foundation
 
 @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
 protocol AuthBackendProtocol: Sendable {
-  func call<T: AuthRPCRequest>(with request: T) async throws -> T.Response
+  func call<T: AuthRPCRequest>(with request: sending T) async throws -> T.Response
 }
 
 @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
@@ -48,7 +48,7 @@ final class AuthBackend: AuthBackendProtocol {
   /// * See FIRAuthInternalErrorCodeRPCResponseDecodingError
   /// - Parameter request: The request.
   /// - Returns: The response.
-  func call<T: AuthRPCRequest>(with request: T) async throws -> T.Response {
+  func call<T: AuthRPCRequest>(with request: sending T) async throws -> T.Response {
     let response = try await callInternal(with: request)
     if let auth = request.requestConfiguration().auth,
        let mfaError = Self.generateMFAError(response: response, auth: auth) {