Skip to content

Commit 7ad4967

Browse files
authored
update thread-safety docs on Storage (#11661)
1 parent d4beb34 commit 7ad4967

File tree

5 files changed

+2
-5
lines changed

5 files changed

+2
-5
lines changed

FirebaseStorage/Sources/Storage.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import FirebaseAuthInterop
2929
/**
3030
* Firebase Storage is a service that supports uploading and downloading binary objects,
3131
* such as images, videos, and other files to Google Cloud Storage. Instances of `Storage`
32-
* are not thread-safe.
32+
* are not thread-safe, but can be accessed from any thread.
3333
*
3434
* If you call `Storage.storage()`, the instance will initialize with the default `FirebaseApp`,
3535
* `FirebaseApp.app()`, and the storage location will come from the provided

FirebaseStorage/Sources/StorageDownloadTask.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import Foundation
2828
* Downloads can currently be returned as `Data` in memory, or as a `URL` to a file on disk.
2929
* Downloads are performed on a background queue, and callbacks are raised on the developer
3030
* specified `callbackQueue` in Storage, or the main queue if left unspecified.
31-
* Currently all downloads must be initiated and managed on the main queue.
3231
*/
3332
@objc(FIRStorageDownloadTask)
3433
open class StorageDownloadTask: StorageObservableTask, StorageTaskManagement {

FirebaseStorage/Sources/StorageObservableTask.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import Foundation
2525
* in task state.
2626
* Observers produce a `StorageHandle`, which is used to keep track of and remove specific
2727
* observers at a later date.
28-
* This class is not thread safe and can only be called on the main thread.
2928
*/
3029
@objc(FIRStorageObservableTask) open class StorageObservableTask: StorageTask {
3130
/**

FirebaseStorage/Sources/StorageTask.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import Foundation
2626
* for metadata and errors.
2727
* Callbacks are always fired on the developer-specified callback queue.
2828
* If no queue is specified, it defaults to the main queue.
29-
* This class is not thread safe, so only call methods on the main thread.
29+
* This class is thread-safe.
3030
*/
3131
@objc(FIRStorageTask) open class StorageTask: NSObject {
3232
/**

FirebaseStorage/Sources/StorageUploadTask.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import Foundation
2828
* Uploads can be initialized from `Data` in memory, or a URL to a file on disk.
2929
* Uploads are performed on a background queue, and callbacks are raised on the developer
3030
* specified `callbackQueue` in Storage, or the main queue if unspecified.
31-
* Currently all uploads must be initiated and managed on the main queue.
3231
*/
3332
@objc(FIRStorageUploadTask) open class StorageUploadTask: StorageObservableTask,
3433
StorageTaskManagement {

0 commit comments

Comments
 (0)