Skip to content

Commit 7df2377

Browse files
Apply suggestions from code review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent ebd9444 commit 7df2377

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

FirebaseAI/Tests/Unit/GenerativeModelGoogleAITests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ final class GenerativeModelGoogleAITests: XCTestCase {
380380
let successURLMetadata = urlContextMetadata.urlMetadata[1]
381381
XCTAssertEqual(successURLMetadata.retrievalStatus, .success)
382382

383-
let errorURLMetadata = try XCTUnwrap(urlContextMetadata.urlMetadata[2])
383+
let errorURLMetadata = urlContextMetadata.urlMetadata[2]
384384
XCTAssertEqual(errorURLMetadata.retrievalStatus, .error)
385385
}
386386

FirebaseAI/Tests/Unit/GenerativeModelVertexAITests.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ final class GenerativeModelVertexAITests: XCTestCase {
539539
XCTAssertEqual(errorURLMetadata.retrievalStatus, .error)
540540
}
541541

542-
func testGenerateContent_success_urlContext_nonexistentRetrievedURL() async throws {
542+
func testGenerateContent_success_urlContext_retrievedURLPresentOnErrorStatus() async throws {
543543
MockURLProtocol.requestHandler = try GenerativeModelTestUtil.httpRequestHandler(
544544
forResource: "unary-success-url-context-missing-retrievedurl",
545545
withExtension: "json",
@@ -551,7 +551,8 @@ final class GenerativeModelVertexAITests: XCTestCase {
551551
let candidate = try XCTUnwrap(response.candidates.first)
552552
let urlContextMetadata = try XCTUnwrap(candidate.urlContextMetadata)
553553
let urlMetadata = try XCTUnwrap(urlContextMetadata.urlMetadata.first)
554-
XCTAssertEqual(urlMetadata.retrievedURL?.absoluteString, "https://example.com/8")
554+
let retrievedURL = try XCTUnwrap(urlMetadata.retrievedURL)
555+
XCTAssertEqual(retrievedURL.absoluteString, "https://example.com/8")
555556
XCTAssertEqual(urlMetadata.retrievalStatus, .error)
556557
}
557558

0 commit comments

Comments
 (0)