Skip to content

Commit 7fa6b95

Browse files
committed
fixes
1 parent b74d065 commit 7fa6b95

File tree

5 files changed

+19
-14
lines changed

5 files changed

+19
-14
lines changed

FirebasePerformance/Sources/Configurations/FPRRemoteConfigFlags+Private.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
#import "FirebasePerformance/Sources/Configurations/FPRRemoteConfigFlags.h"
1616

17-
#import "FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h"
17+
@import FirebaseRemoteConfig;
1818

1919
NS_ASSUME_NONNULL_BEGIN
2020

FirebasePerformance/Tests/Unit/Configurations/FPRFakeRemoteConfig.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
#import <Foundation/Foundation.h>
1616

17-
#import "FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h"
17+
@import FirebaseRemoteConfig;
1818

1919
@import FirebaseRemoteConfig;
2020

@@ -38,6 +38,8 @@ NS_ASSUME_NONNULL_BEGIN
3838
/** @brief Different configurations values that needs to be stored and returned. */
3939
@property(nonatomic) NSMutableDictionary<NSString *, FIRRemoteConfigValue *> *configValues;
4040

41+
- (instancetype)init;
42+
4143
/**
4244
* Fake fetch call for fetching configs. Calling this method will just call the completionHandler.
4345
*

FirebasePerformance/Tests/Unit/Configurations/FPRRemoteConfigFlagsTest.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222

2323
#import "FirebasePerformance/Tests/Unit/Configurations/FPRFakeRemoteConfig.h"
2424

25+
@import FirebaseRemoteConfig;
26+
2527
static NSInteger const kLogSource = 462; // LogRequest_LogSource_Fireperf
2628

2729
@interface FPRRemoteConfigFlagsTest : XCTestCase

FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -49,18 +49,6 @@ NS_ASSUME_NONNULL_BEGIN
4949
+ (FIRRemoteConfig *)remoteConfigWithFIRNamespace:(NSString *)remoteConfigNamespace
5050
NS_SWIFT_NAME(remoteConfig(FIRNamespace:));
5151

52-
/// Returns the FIRRemoteConfig instance for your namespace and for the default 3P developer's app.
53-
/// This singleton object contains the complete set of Remote Config parameter values available to
54-
/// the app, including the Active Config and Default Config. This object also caches values fetched
55-
/// from the Remote Config Server until they are copied to the Active Config by calling
56-
/// activateFetched. When you fetch values from the Remote Config Server using the default Firebase
57-
/// namespace service, you should use this class method to create a shared instance of the
58-
/// FIRRemoteConfig object to ensure that your app will function properly with the Remote Config
59-
/// Server and the Firebase service.
60-
+ (FIRRemoteConfig *)remoteConfigWithFIRNamespace:(NSString *)remoteConfigNamespace
61-
app:(FIRApp *)app
62-
NS_SWIFT_NAME(remoteConfig(FIRNamespace:app:));
63-
6452
/// Register RolloutsStateSubcriber to FIRRemoteConfig instance
6553
- (void)addRemoteConfigInteropSubscriber:(id<FIRRolloutsStateSubscriber> _Nonnull)subscriber;
6654

FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,5 +354,18 @@ typedef void (^FIRRemoteConfigUpdateCompletion)(FIRRemoteConfigUpdate *_Nullable
354354
userDefaults:(nullable NSUserDefaults *)userDefaults
355355
analytics:(nullable id<FIRAnalyticsInterop>)analytics;
356356

357+
/// Firebase INTERNAL use only!
358+
/// Returns the FIRRemoteConfig instance for your namespace and for the default 3P developer's app.
359+
/// This singleton object contains the complete set of Remote Config parameter values available to
360+
/// the app, including the Active Config and Default Config. This object also caches values fetched
361+
/// from the Remote Config Server until they are copied to the Active Config by calling
362+
/// activateFetched. When you fetch values from the Remote Config Server using the default Firebase
363+
/// namespace service, you should use this class method to create a shared instance of the
364+
/// FIRRemoteConfig object to ensure that your app will function properly with the Remote Config
365+
/// Server and the Firebase service.
366+
+ (FIRRemoteConfig *)remoteConfigWithFIRNamespace:(NSString *)remoteConfigNamespace
367+
app:(FIRApp *)app
368+
NS_SWIFT_NAME(remoteConfig(FIRNamespace:app:));
369+
357370
@end
358371
NS_ASSUME_NONNULL_END

0 commit comments

Comments
 (0)