[Infra] Migrate notices GHA to use upload-artifact@v4 (#14038)

Author: ncooke3

.github/actions/notices_generation/action.yml

@@ -40,7 +40,7 @@ runs:
       fi
     shell: bash
   - name: Upload artifacts
-    uses: actions/upload-artifact@v3
+    uses: actions/upload-artifact@v4
     with:
       name: notices
       path: ${{ inputs.notices-path }}