Skip to content

Commit 80750eb

Browse files
committed
prerelease, if changes, todo
1 parent 35efc74 commit 80750eb

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

.github/workflows/prerelease.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,17 @@ jobs:
6161

6262
quickstart:
6363
# Don't run on private repo unless it is a PR.
64-
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request'
64+
if: |
65+
github.repository == 'firebase/firebase-ios-sdk' &&
66+
contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name)
6567
strategy:
6668
fail-fast: false
6769
matrix:
6870
include:
6971
- product: Performance
7072
run_tests: true
7173
- product: Storage
72-
run_tests: true
74+
run_tests: false
7375
- product: Config
7476
run_tests: true
7577
- product: Messaging
@@ -112,8 +114,7 @@ jobs:
112114
timeout_minutes: 15
113115
max_attempts: 3
114116
retry_wait_seconds: 120
115-
# TODO(ncooke3): Remove SPM=true and instead change default value in quickstart-ios/scripts/test.sh
116-
command: SPM=true DIR=${{ matrix.product }} scripts/test_quickstart.sh ${{ matrix.product }} ${{ matrix.run_tests }}
117+
command: DIR=${{ matrix.product }} scripts/test_quickstart.sh ${{ matrix.product }} ${{ matrix.run_tests }}
117118
# Failure sequence to upload artifact.
118119
- name: Remove data before upload.
119120
# if: ${{ failure() }}

.github/workflows/release.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,9 @@ jobs:
5656
# path: quickstart-ios/
5757

5858
quickstart:
59-
# Don't run on private repo unless it is a PR.
60-
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request'
59+
if: |
60+
github.repository == 'firebase/firebase-ios-sdk' &&
61+
contains(fromJSON('["schedule", "pull_request", "workflow_dispatch"]'), github.event_name)
6162
strategy:
6263
fail-fast: false
6364
matrix:
@@ -108,8 +109,7 @@ jobs:
108109
timeout_minutes: 15
109110
max_attempts: 3
110111
retry_wait_seconds: 120
111-
# TODO(ncooke3): Remove SPM=true and instead change default value in quickstart-ios/scripts/test.sh
112-
command: SPM=true DIR=${{ matrix.product }} scripts/test_quickstart.sh ${{ matrix.product }} ${{ matrix.run_tests }}
112+
command: DIR=${{ matrix.product }} scripts/test_quickstart.sh ${{ matrix.product }} ${{ matrix.run_tests }}
113113
- name: Remove data before upload
114114
# if: ${{ failure() }}
115115
run: scripts/remove_data.sh ${{ matrix.product }}

0 commit comments

Comments
 (0)