Fix Windows and Fuzzing builds (#5616)

* Add missing dependency on OpenSSL::Crypto

This should fix compilation errors about a missing openssl/err.h when
building against a prebuilt copy of the library.

* Fix Defer usage on Windows

* Fix signedness warnings in CountingQueryEngine

* Rename status_posix.cc to status_errno.cc

Windows excludes *_posix.cc but Status::FromErrno is not conditionally
defined.

This fixes a missing symbol error when building status tests.

Author: wilhuff

Firestore/core/CMakeLists.txt

@@ -133,6 +133,13 @@ target_link_libraries(
   absl_strings
 )
 
+if(HAVE_OPENSSL_RAND_H)
+  target_link_libraries(
+    firestore_util PRIVATE
+    OpenSSL::Crypto
+  )
+endif()
+
 if(APPLE)
   target_link_libraries(
     firestore_util PUBLIC

Firestore/core/src/util/filesystem_win.cc

@@ -37,7 +37,7 @@ namespace util {
 
 StatusOr<Path> Filesystem::AppDataDir(absl::string_view app_name) {
   wchar_t* path = nullptr;
-  auto cleanup = defer([&] { CoTaskMemFree(path); });
+  Defer cleanup([&] { CoTaskMemFree(path); });
 
   HRESULT hr = SHGetKnownFolderPath(FOLDERID_LocalAppData, 0, nullptr, &path);
   if (FAILED(hr)) {

Firestore/core/src/util/status_posix.cc renamed to Firestore/core/src/util/status_errno.cc

@@ -66,15 +66,15 @@ class CountingQueryEngine : public QueryEngine {
    * Returns the number of documents returned by the RemoteDocumentCache's
    * `GetMatching()` API (since the last call to `ResetCounts()`)
    */
-  int documents_read_by_query() const {
+  size_t documents_read_by_query() const {
     return documents_read_by_query_;
   }
 
   /**
    * Returns the number of documents returned by the RemoteDocumentCache's
    * `Get()` and `GetAll()` APIs (since the last call to `ResetCounts()`)
    */
-  int documents_read_by_key() const {
+  size_t documents_read_by_key() const {
     return documents_read_by_key_;
   }
 
@@ -83,7 +83,7 @@ class CountingQueryEngine : public QueryEngine {
    * `getAllMutationBatchesAffectingQuery()` API (since the last call to
    * `ResetCounts()`)
    */
-  int mutations_read_by_query() const {
+  size_t mutations_read_by_query() const {
     return mutations_read_by_query_;
   }
 
@@ -93,7 +93,7 @@ class CountingQueryEngine : public QueryEngine {
    * `AllMutationBatchesAffectingDocumentKeys()` APIs (since the last call to
    * `ResetCounts()`)
    */
-  int mutations_read_by_key() const {
+  size_t mutations_read_by_key() const {
     return mutations_read_by_key_;
   }
 
@@ -107,10 +107,10 @@ class CountingQueryEngine : public QueryEngine {
   std::unique_ptr<WrappedMutationQueue> mutation_queue_;
   std::unique_ptr<WrappedRemoteDocumentCache> remote_documents_;
 
-  int mutations_read_by_query_ = 0;
-  int mutations_read_by_key_ = 0;
-  int documents_read_by_query_ = 0;
-  int documents_read_by_key_ = 0;
+  size_t mutations_read_by_query_ = 0;
+  size_t mutations_read_by_key_ = 0;
+  size_t documents_read_by_query_ = 0;
+  size_t documents_read_by_key_ = 0;
 };
 
 /** A MutationQueue that counts document reads. */