Fixed macOS conditional check. (#2245)

* Fixed macOS conditional check.

Turns out TARGET_OS_MAC is 1 for macOS and iOS, we should be using
TARGET_OS_OSX instead.

Tweet with some history: https://twitter.com/gparker/status/836341915037515778

* Update README.

Author: ryanwilson

Firestore/Source/Local/FSTLevelDB.mm

@@ -383,7 +383,7 @@ + (Path)documentsDirectory {
       NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
   return Path::FromNSString(directories[0]).AppendUtf8(kReservedPathComponent);
 
-#elif TARGET_OS_MAC
+#elif TARGET_OS_OSX
   std::string dotPrefixed = absl::StrCat(".", kReservedPathComponent);
   return Path::FromNSString(NSHomeDirectory()).AppendUtf8(dotPrefixed);
 

GoogleUtilities/CHANGELOG.md

@@ -1,5 +1,6 @@
 # Unreleased
-- Fix `pod lib lint GoogleUtilities.podspec --use-libraries` regression. (#2130)
+- Fixed `pod lib lint GoogleUtilities.podspec --use-libraries` regression. (#2130)
+- Fixed macOS conditional check in UserDefaults. (#2245)
 
 # 5.3.6
 - Fix nullability issues. (#2079)

GoogleUtilities/Example/Tests/UserDefaults/GULUserDefaultsTests.m

@@ -432,15 +432,15 @@ - (void)testUserDefaultNotifications {
 }
 
 - (void)testSynchronizeToDisk {
-#if TARGET_OS_MAC
+#if TARGET_OS_OSX
   // `NSFileManager` has trouble reading the files in `~/Library` even though the
   // `removeItemAtPath:` call works. Watching Finder while stepping through this test shows that the
   // file does get created and removed properly. When using LLDB to call `fileExistsAtPath:` the
   // correct return value of `YES` is returned, but in this test it returns `NO`. Best guess is the
   // test app is sandboxed and `NSFileManager` is refusing to read the directory.
   // TODO: Investigate the failure and re-enable this test.
   return;
-#endif  // TARGET_OS_MAC
+#endif  // TARGET_OS_OSX
   NSString *suiteName = [NSString stringWithFormat:@"another_test_suite"];
   NSString *filePath = [self filePathForPreferencesName:suiteName];
   NSFileManager *fileManager = [NSFileManager defaultManager];

GoogleUtilities/UserDefaults/GULUserDefaults.m

@@ -201,7 +201,7 @@ - (void)synchronize {
 - (void)clearAllData {
   // On macOS, using `kCFPreferencesCurrentHost` will not set all the keys necessary to match
   // `NSUserDefaults`.
-#if TARGET_OS_MAC
+#if TARGET_OS_OSX
   CFStringRef host = kCFPreferencesAnyHost;
 #else
   CFStringRef host = kCFPreferencesCurrentHost;