Skip to content

Commit 83bf492

Browse files
update changelog for messaging and instanceID (#5368)
1 parent c056540 commit 83bf492

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

Firebase/InstanceID/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# 2020-04 -- 4.3.4
2+
- [changed] Internal cleanup and remove repetitive local notification. (#5339)
3+
14
# 2020-03 -- 4.3.3
25
- [fixed] Fixed provisioning profile location for catalyst. (#5048)
36
- [fixed] Fixed crash when passing a nil handler to deleteToken request. (#5247)

Firebase/Messaging/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# 2020-04 -- v4.3.1
2+
- [fixed] Fixed an issue that when a token is deleted, the token refresh notificaiton and delegate is not triggered. (#5338)
3+
14
# 2020-02 -- v4.3.0
25
- [changed] Deprecated FCM direct channel messaging via `shouldEstablishDirectChannel`. Instead, use APNs for downstream message delivery. Add `content_available` key to your payload if you want to continue use legacy APIs, but we strongly recommend HTTP v1 API as it provides full APNs support. The deprecated API will be removed in Firebase 7. (#4710)
36
- [changed] Deprecated upstream messaging API. For realtime updates, use Cloud Firestore, Realtime Database, or other services. The deprecated API will be removed in Firebase 7. (#4710)

Firebase/Messaging/FIRMessaging.m

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -940,8 +940,7 @@ - (void)defaultInstanceIDTokenWasRefreshed:(NSNotification *)notification {
940940
// Retrieve the Instance ID default token, and should notify delegate and
941941
// trigger notification as long as the token is different from previous state.
942942
NSString *oldToken = self.defaultFcmToken;
943-
NSString *token = [(NSString *)notification.object copy];
944-
self.defaultFcmToken = [token copy];
943+
self.defaultFcmToken = [(NSString *)notification.object copy];
945944
if ((self.defaultFcmToken.length && oldToken.length &&
946945
![self.defaultFcmToken isEqualToString:oldToken]) ||
947946
self.defaultFcmToken.length != oldToken.length) {

0 commit comments

Comments
 (0)