Skip to content

Commit 8b3ee5f

Browse files
paulb777granluo
andauthored
Fix Crashlytics qs in nightly zip test (#8049)
* update base name check. Co-authored-by: granluo <[email protected]>
1 parent fd36167 commit 8b3ee5f

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

.github/workflows/zip.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,11 @@ jobs:
214214
cp quickstart-ios/crashlytics/Firebase/upload-symbols quickstart-ios/crashlytics
215215
chmod +x quickstart-ios/crashlytics/run
216216
chmod +x quickstart-ios/crashlytics/upload-symbols
217-
- name: Setup swift quickstart
218-
run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh
217+
# TODO(#8057): Restore Swift Quickstart
218+
# - name: Setup swift quickstart
219+
# run: |
220+
# SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" NON_FIREBASE_SDKS="ReachabilitySwift" scripts/setup_quickstart_framework.sh \
221+
# "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/*
219222
- name: Install Secret GoogleService-Info.plist
220223
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-crashlytics.plist.gpg \
221224
quickstart-ios/crashlytics/GoogleService-Info.plist "$plist_secret"
@@ -224,8 +227,8 @@ jobs:
224227
quickstart-ios/TestUtils/FIREGSignInInfo.h "$signin_secret"
225228
- name: Test Quickstart
226229
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
227-
- name: Test Swift Quickstart
228-
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift)
230+
# - name: Test Swift Quickstart
231+
# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift)
229232
- name: Remove data before upload
230233
if: ${{ failure() }}
231234
run: scripts/remove_data.sh crashlytics

scripts/setup_quickstart_framework.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ if [ ! -f "Firebase/module.modulemap" ]; then
3535
fi
3636
for file in "$@"
3737
do
38-
if [ ! -f "Firebase/${file}" ]; then
38+
if [ ! -f "Firebase/$(basename ${file})" ]; then
3939
cp -R ${file} Firebase/
4040
fi
4141
done

0 commit comments

Comments
 (0)