Skip to content

Commit 8c68475

Browse files
authored
Disable Sessions due to usage (#10796)
1 parent 549b23d commit 8c68475

File tree

2 files changed

+17
-6
lines changed

2 files changed

+17
-6
lines changed

FirebaseSessions/Sources/Settings/SessionsSettings.swift

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,22 @@ class SessionsSettings: SettingsProtocol {
4646
}
4747

4848
var sessionsEnabled: Bool {
49-
// Order of precendence LocalOverrides > Remote Settings > SDK Defaults
49+
// TODO: Remove this block before release
50+
// Disabling the SDK because some customers seem to be building from master
51+
// Uncomment the code below before release
5052
if let sessionEnabled = localOverrides.sessionsEnabled {
5153
return sessionEnabled
52-
} else if let sessionEnabled = remoteSettings.sessionsEnabled {
53-
return sessionEnabled
5454
}
55-
return sdkDefaults.sessionsEnabled!
55+
return false
56+
57+
// TODO: uncomment before release
58+
// // Order of precendence LocalOverrides > Remote Settings > SDK Defaults
59+
// if let sessionEnabled = localOverrides.sessionsEnabled {
60+
// return sessionEnabled
61+
// } else if let sessionEnabled = remoteSettings.sessionsEnabled {
62+
// return sessionEnabled
63+
// }
64+
// return sdkDefaults.sessionsEnabled!
5665
}
5766

5867
var sessionTimeout: TimeInterval {

FirebaseSessions/Tests/Unit/SessionsSettingsTests.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ class SessionsSettingsTests: XCTestCase {
8282
remoteSettings: remoteSettings
8383
)
8484

85-
XCTAssertTrue(sessionSettings.sessionsEnabled)
85+
// TODO: uncomment before release
86+
// XCTAssertTrue(sessionSettings.sessionsEnabled)
8687
XCTAssertEqual(sessionSettings.samplingRate, 1.0)
8788
XCTAssertEqual(sessionSettings.sessionTimeout, 30 * 60)
8889
}
@@ -109,7 +110,8 @@ class SessionsSettingsTests: XCTestCase {
109110
remoteSettings: remoteSettings
110111
)
111112

112-
XCTAssertTrue(sessionSettings.sessionsEnabled)
113+
// TODO: uncomment before release
114+
// XCTAssertTrue(sessionSettings.sessionsEnabled)
113115
XCTAssertEqual(sessionSettings.samplingRate, 0.8)
114116
XCTAssertEqual(sessionSettings.sessionTimeout, 50)
115117
}

0 commit comments

Comments
 (0)