change addStage to rawStage

Author: cherylEnkidu

Firestore/Source/API/FIRPipelineBridge.mm

@@ -46,7 +46,6 @@
 #include "Firestore/core/src/util/string_apple.h"
 
 using firebase::firestore::api::AddFields;
-using firebase::firestore::api::AddStage;
 using firebase::firestore::api::AggregateFunction;
 using firebase::firestore::api::AggregateStage;
 using firebase::firestore::api::CollectionGroupSource;
@@ -65,6 +64,7 @@
 using firebase::firestore::api::OffsetStage;
 using firebase::firestore::api::Ordering;
 using firebase::firestore::api::Pipeline;
+using firebase::firestore::api::RawStage;
 using firebase::firestore::api::RemoveFieldsStage;
 using firebase::firestore::api::ReplaceWith;
 using firebase::firestore::api::Sample;
@@ -782,12 +782,12 @@ - (id)initWithField:(FIRExprBridge *)field indexField:(NSString *_Nullable)index
 
 @end
 
-@implementation FIRAddStageBridge {
+@implementation FIRRawStageBridge {
   NSString *_name;
   NSArray<FIRExprBridge *> *_params;
   NSDictionary<NSString *, FIRExprBridge *> *_Nullable _options;
   Boolean isUserDataRead;
-  std::shared_ptr<AddStage> cpp_generic_stage;
+  std::shared_ptr<RawStage> cpp_generic_stage;
 }
 
 - (id)initWithName:(NSString *)name
@@ -815,7 +815,7 @@ - (id)initWithName:(NSString *)name
         cpp_options[MakeString(key)] = [_options[key] cppExprWithReader:reader];
       }
     }
-    cpp_generic_stage = std::make_shared<AddStage>(MakeString(_name), std::move(cpp_params),
+    cpp_generic_stage = std::make_shared<RawStage>(MakeString(_name), std::move(cpp_params),
                                                    std::move(cpp_options));
   }
 

Firestore/Source/Public/FirebaseFirestore/FIRPipelineBridge.h

@@ -195,8 +195,8 @@ NS_SWIFT_NAME(UnnestStageBridge)
 @end
 
 NS_SWIFT_SENDABLE
-NS_SWIFT_NAME(AddStageBridge)
-@interface FIRAddStageBridge : FIRStageBridge
+NS_SWIFT_NAME(RawStageBridge)
+@interface FIRRawStageBridge : FIRStageBridge
 - (id)initWithName:(NSString *)name
             params:(NSArray<FIRExprBridge *> *)params
            options:(NSDictionary<NSString *, FIRExprBridge *> *_Nullable)options;

Firestore/Swift/Source/SwiftAPI/Pipeline/Pipeline.swift

@@ -699,7 +699,7 @@ public struct Pipeline: @unchecked Sendable {
   /// ```swift
   /// // let pipeline: Pipeline = ...
   /// // Example: Assuming a hypothetical backend stage "customFilterV2".
-  /// let genericPipeline = pipeline.addStage(
+  /// let genericPipeline = pipeline.rawStage(
   ///   name: "customFilterV2",
   ///   params: [Field("userScore"), 80], // Ordered parameters.
   ///   options: ["mode": "strict", "logLevel": 2]  // Optional named parameters.
@@ -712,10 +712,10 @@ public struct Pipeline: @unchecked Sendable {
   ///   - params: An array of ordered, `Sendable` parameters for the stage.
   ///   - options: Optional dictionary of named, `Sendable` parameters.
   /// - Returns: A new `Pipeline` object with this stage appended.
-  public func addStage(name: String, params: [Sendable],
+  public func rawStage(name: String, params: [Sendable],
                        options: [String: Sendable]? = nil) -> Pipeline {
     return Pipeline(
-      stages: stages + [AddStage(name: name, params: params, options: options)],
+      stages: stages + [RawStage(name: name, params: params, options: options)],
       db: db
     )
   }

Firestore/Swift/Source/SwiftAPI/Stages.swift

@@ -341,7 +341,7 @@ class Unnest: Stage {
 }
 
 @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
-class AddStage: Stage {
+class RawStage: Stage {
   let name: String
   let bridge: StageBridge
   private var params: [Sendable]
@@ -353,6 +353,6 @@ class AddStage: Stage {
     self.options = options
     let bridgeParams = params.map { Helper.sendableToExpr($0).toBridge() }
     let bridgeOptions = options?.mapValues { Helper.sendableToExpr($0).toBridge() }
-    bridge = AddStageBridge(name: name, params: bridgeParams, options: bridgeOptions)
+    bridge = RawStageBridge(name: name, params: bridgeParams, options: bridgeOptions)
   }
 }

Firestore/Swift/Tests/Integration/PipelineApiTests.swift

@@ -263,20 +263,20 @@ final class PipelineTests: FSTIntegrationTestCase {
     // ... }
   }
 
-  func testAddStage() async throws {
+  func testRawStage() async throws {
     // Assume we don't have a built-in "where" stage, the customer could still
-    // add this stage by calling addStage, passing the name of the stage "where",
+    // add this stage by calling rawStage, passing the name of the stage "where",
     // and providing positional argument values.
     _ = db.pipeline().collection("books")
-      .addStage(name: "where",
+      .rawStage(name: "where",
                 params: [Field("published").lt(1900)])
       .select("title", "author")
 
     // In cases where the stage also supports named argument values, then these can be
     // provided with a third argument that maps the argument name to value.
     // Note that these named arguments are always optional in the stage definition.
     _ = db.pipeline().collection("books")
-      .addStage(name: "where",
+      .rawStage(name: "where",
                 params: [Field("published").lt(1900)],
                 options: ["someOptionalParamName": "the argument value for this param"])
       .select("title", "author")

Firestore/core/src/api/stages.cc

@@ -393,7 +393,7 @@ google_firestore_v1_Pipeline_Stage Unnest::to_proto() const {
   return result;
 }
 
-AddStage::AddStage(
+RawStage::RawStage(
     std::string name,
     std::vector<std::shared_ptr<Expr>> params,
     std::unordered_map<std::string, std::shared_ptr<Expr>> options)
@@ -402,7 +402,7 @@ AddStage::AddStage(
       options_(std::move(options)) {
 }
 
-google_firestore_v1_Pipeline_Stage AddStage::to_proto() const {
+google_firestore_v1_Pipeline_Stage RawStage::to_proto() const {
   google_firestore_v1_Pipeline_Stage result;
   result.name = nanopb::MakeBytesArray(name_);