Skip to content

Commit 8ec15fd

Browse files
authored
[Infra] Simplify Client app schemes (#14333)
1 parent 52d9152 commit 8ec15fd

File tree

11 files changed

+60
-572
lines changed

11 files changed

+60
-572
lines changed

.github/workflows/client_app.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ jobs:
3030
matrix:
3131
#TODO(ncooke3): Add multi-platform support: tvOS, macOS, catalyst
3232
platform: [iOS]
33-
scheme: [ClientApp-iOS13]
34-
# TODO(ncooke3): Re-enable after updating Firestore binary.
35-
#scheme: [ClientApp, ClientApp-iOS13]
33+
scheme: [ClientApp]
3634
steps:
3735
- uses: actions/checkout@v4
3836
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
@@ -53,7 +51,7 @@ jobs:
5351
matrix:
5452
#TODO(ncooke3): Add multi-platform support: tvOS, macOS, catalyst
5553
platform: [iOS]
56-
scheme: [ClientApp, ClientApp-iOS13]
54+
scheme: [ClientApp]
5755
steps:
5856
- uses: actions/checkout@v4
5957
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
@@ -70,7 +68,7 @@ jobs:
7068
runs-on: macos-14
7169
strategy:
7270
matrix:
73-
scheme: [ClientApp-CocoaPods, ClientApp-CocoaPods-iOS13]
71+
scheme: [ClientApp-CocoaPods]
7472
steps:
7573
- uses: actions/checkout@v4
7674
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126

IntegrationTesting/ClientApp/ClientApp.xcodeproj/project.pbxproj

Lines changed: 13 additions & 405 deletions
Large diffs are not rendered by default.

IntegrationTesting/ClientApp/Podfile

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ target 'ClientApp-CocoaPods' do
1818
pod 'FirebaseRemoteConfig', :path => '../../'
1919
pod 'FirebaseRemoteConfigInterop', :path => '../../'
2020
pod 'FirebaseAppDistribution', :path => '../../'
21+
pod 'FirebaseAuthInterop', :path => '../../'
22+
pod 'FirebaseAuth', :path => '../../'
2123
pod 'FirebaseCrashlytics', :path => '../../'
2224
pod 'FirebaseDatabase', :path => '../../'
2325
pod 'FirebaseDynamicLinks', :path => '../../'
@@ -27,19 +29,8 @@ target 'ClientApp-CocoaPods' do
2729
pod 'FirebaseInAppMessaging', :path => '../../'
2830
pod 'FirebaseMessaging', :path => '../../'
2931
pod 'FirebaseSessions', :path => '../../'
32+
pod 'FirebaseStorage', :path => '../../'
3033
pod 'FirebasePerformance', :path => '../../'
3134
pod 'FirebaseMLModelDownloader', :path => '../../'
3235
pod 'Firebase', :path => '../../'
3336
end
34-
35-
target 'ClientApp-CocoaPods-iOS13' do
36-
platform :ios, '13.0'
37-
38-
use_frameworks!
39-
40-
pod 'FirebaseAnalytics' # Binary pods don't work with `:path`.
41-
pod 'FirebaseAuth', :path => '../../' # Requires iOS 13.0+
42-
pod 'FirebaseAuthInterop', :path => '../../'
43-
pod 'FirebaseInAppMessaging', :path => '../../'
44-
pod 'FirebaseStorage', :path => '../../'
45-
end

IntegrationTesting/ClientApp/Shared-iOS13+/objc-header-import-test.m

Lines changed: 0 additions & 45 deletions
This file was deleted.

IntegrationTesting/ClientApp/Shared-iOS13+/objc-module-import-test.m

Lines changed: 0 additions & 28 deletions
This file was deleted.

IntegrationTesting/ClientApp/Shared-iOS13+/objcxx-header-import-test.mm

Lines changed: 0 additions & 46 deletions
This file was deleted.

IntegrationTesting/ClientApp/Shared-iOS13+/swift-import-test.swift

Lines changed: 0 additions & 23 deletions
This file was deleted.

IntegrationTesting/ClientApp/Shared-iOS12+/objc-header-import-test.m renamed to IntegrationTesting/ClientApp/Shared/objc-header-import-test.m

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@
2121
#import <FirebaseABTesting/FirebaseABTesting.h>
2222
#import <FirebaseAnalytics/FirebaseAnalytics.h>
2323
#import <FirebaseAppCheck/FirebaseAppCheck.h>
24-
#import "Firebase.h"
25-
#import "FirebaseABTesting/FirebaseABTesting.h"
26-
#import "FirebaseAnalytics/FirebaseAnalytics.h"
24+
#import <FirebaseAuth/FirebaseAuth.h>
2725
#import "FirebaseAppCheck/FirebaseAppCheck.h"
26+
#import "FirebaseAuth/FirebaseAuth.h"
2827
#if TARGET_OS_IOS && !TARGET_OS_MACCATALYST
2928
#import <FirebaseAppDistribution/FirebaseAppDistribution.h>
3029
#import "FirebaseAppDistribution/FirebaseAppDistribution.h"
@@ -53,3 +52,16 @@
5352
#endif
5453
#import <FirebaseRemoteConfig/FirebaseRemoteConfig.h>
5554
#import "FirebaseRemoteConfig/FirebaseRemoteConfig.h"
55+
56+
#ifdef COCOAPODS
57+
#import "FirebaseStorage/FIRStorageTypedefs.h"
58+
59+
@interface TestImports : NSObject
60+
@end
61+
62+
@implementation TestImports
63+
- (FIRAuth *)testImports {
64+
return [FIRAuth auth];
65+
}
66+
@end
67+
#endif

IntegrationTesting/ClientApp/Shared-iOS12+/objc-module-import-test.m renamed to IntegrationTesting/ClientApp/Shared/objc-module-import-test.m

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,19 @@
2424
#if TARGET_OS_IOS && !TARGET_OS_MACCATALYST
2525
@import FirebaseAppDistribution;
2626
#endif
27+
@import FirebaseAuth;
2728
@import FirebaseCore;
2829
@import FirebaseCrashlytics;
29-
@import FirebaseDatabase;
3030
#if TARGET_OS_IOS && !TARGET_OS_MACCATALYST
3131
@import FirebaseDynamicLinks;
3232
#endif
33-
@import FirebaseFirestore;
34-
@import FirebaseFunctions;
35-
@import FirebaseInstallations;
36-
@import FirebaseMessaging;
3733
#if (TARGET_OS_IOS && !TARGET_OS_MACCATALYST) || TARGET_OS_TV
3834
@import FirebasePerformance;
3935
@import FirebaseInAppMessaging;
4036
#endif
37+
@import FirebaseFirestore;
38+
@import FirebaseFunctions;
39+
@import FirebaseInstallations;
40+
@import FirebaseMessaging;
41+
@import FirebaseStorage;
4142
@import FirebaseRemoteConfig;

IntegrationTesting/ClientApp/Shared-iOS12+/objcxx-header-import-test.mm renamed to IntegrationTesting/ClientApp/Shared/objcxx-header-import-test.mm

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,12 @@
2121
#import <FirebaseABTesting/FirebaseABTesting.h>
2222
#import <FirebaseAnalytics/FirebaseAnalytics.h>
2323
#import <FirebaseAppCheck/FirebaseAppCheck.h>
24+
#import <FirebaseAuth/FirebaseAuth.h>
2425
#import "Firebase.h"
2526
#import "FirebaseABTesting/FirebaseABTesting.h"
2627
#import "FirebaseAnalytics/FirebaseAnalytics.h"
2728
#import "FirebaseAppCheck/FirebaseAppCheck.h"
29+
#import "FirebaseAuth/FirebaseAuth.h"
2830
#if TARGET_OS_IOS && !TARGET_OS_MACCATALYST
2931
#import <FirebaseAppDistribution/FirebaseAppDistribution.h>
3032
#import "FirebaseAppDistribution/FirebaseAppDistribution.h"
@@ -53,3 +55,16 @@
5355
#endif
5456
#import <FirebaseRemoteConfig/FirebaseRemoteConfig.h>
5557
#import "FirebaseRemoteConfig/FirebaseRemoteConfig.h"
58+
59+
#ifdef COCOAPODS
60+
#import "FirebaseStorage/FIRStorageTypedefs.h"
61+
62+
@interface TestImportsCxx : NSObject
63+
@end
64+
65+
@implementation TestImportsCxx
66+
- (FIRAuth *)testImports {
67+
return [FIRAuth auth];
68+
}
69+
@end
70+
#endif

0 commit comments

Comments
 (0)